git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Aneesh Kumar" <aneesh.kumar@gmail.com>
To: "Git Mailing List" <git@vger.kernel.org>
Subject: blameview and file line number
Date: Tue, 30 Jan 2007 12:55:44 +0530	[thread overview]
Message-ID: <cc723f590701292325k1c85d9edgb9e72ae380fcaad7@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 79 bytes --]

Is it a typo or intentional ? I found the blameview output confusing.

-aneesh

[-- Attachment #2: blameview.diff --]
[-- Type: text/x-patch, Size: 437 bytes --]

diff --git a/contrib/blameview/blameview.perl b/contrib/blameview/blameview.perl
index a55f799..e8bcb1b 100755
--- a/contrib/blameview/blameview.perl
+++ b/contrib/blameview/blameview.perl
@@ -62,7 +62,7 @@ sub flush_blame_line {
 	for(my $i = 0; $i < $cnt; $i++) {
 		@{$fileview->{data}->[$lno+$i-1]}[0,1,2] =
 		    (substr($commit, 0, 8), $info,
-		     $filename . ':' . ($s_lno+$i));
+		     $filename . ':' . ($lno+$i));
 	}
 }
 

             reply	other threads:[~2007-01-30  7:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-30  7:25 Aneesh Kumar [this message]
2007-01-30  8:33 ` blameview and file line number Junio C Hamano
2007-01-30  9:12   ` Aneesh Kumar
2007-01-30 10:39     ` Junio C Hamano
2007-01-30 15:48       ` Shawn O. Pearce
2007-01-30 14:06 ` Jeff King
2007-01-30 14:08   ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc723f590701292325k1c85d9edgb9e72ae380fcaad7@mail.gmail.com \
    --to=aneesh.kumar@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).