git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* gc.auto bug in 1.6.5.7
@ 2010-01-06 17:59 Jon Nelson
  2010-01-06 18:31 ` Brandon Casey
  0 siblings, 1 reply; 3+ messages in thread
From: Jon Nelson @ 2010-01-06 17:59 UTC (permalink / raw)
  To: git

It would appear that there is a bug in git, at least as of 1.6.5.7, in
the gc command.
When gc.auto is non-zero, it appears to consider packfiles as "loose"
- this conflicts with pack.packSizeLimit, insofar as I have
pack.packSizeLimit set to 2M (which appears to work).  If gc.auto is,
say, 50 - once I exceed 50 2MB packs then gc --auto repacks *every
single time* it is run. This is unexpected, at least.

-- 
Jon

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: gc.auto bug in 1.6.5.7
  2010-01-06 17:59 gc.auto bug in 1.6.5.7 Jon Nelson
@ 2010-01-06 18:31 ` Brandon Casey
  2010-01-06 22:27   ` Jon Nelson
  0 siblings, 1 reply; 3+ messages in thread
From: Brandon Casey @ 2010-01-06 18:31 UTC (permalink / raw)
  To: Jon Nelson; +Cc: git

Jon Nelson wrote:
> It would appear that there is a bug in git, at least as of 1.6.5.7, in
> the gc command.
> When gc.auto is non-zero, it appears to consider packfiles as "loose"
> - this conflicts with pack.packSizeLimit, insofar as I have
> pack.packSizeLimit set to 2M (which appears to work).  If gc.auto is,
> say, 50 - once I exceed 50 2MB packs then gc --auto repacks *every
> single time* it is run. This is unexpected, at least.

There is also a gc.autopacklimit which controls auto-gc'ing based on
the number of packs.  The default is 50 and it does not consider the
pack.packSizeLimit setting when deciding whether or not to auto-gc.
It can be raised, or it can be disabled by setting it to zero.

The ideal number of packs is one, but if you limit the size of packs
to be very small, then you will quickly grow the number of packs.
Perhaps autogc should only count packs that are much smaller than
pack.packSizeLimit?  Looks like there is already a comment in
builtin-gc.c suggesting something similar.

-brandon

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: gc.auto bug in 1.6.5.7
  2010-01-06 18:31 ` Brandon Casey
@ 2010-01-06 22:27   ` Jon Nelson
  0 siblings, 0 replies; 3+ messages in thread
From: Jon Nelson @ 2010-01-06 22:27 UTC (permalink / raw)
  Cc: git

On Wed, Jan 6, 2010 at 12:31 PM, Brandon Casey
<brandon.casey.ctr@nrlssc.navy.mil> wrote:
> Jon Nelson wrote:
>> It would appear that there is a bug in git, at least as of 1.6.5.7, in
>> the gc command.
>> When gc.auto is non-zero, it appears to consider packfiles as "loose"
>> - this conflicts with pack.packSizeLimit, insofar as I have
>> pack.packSizeLimit set to 2M (which appears to work).  If gc.auto is,
>> say, 50 - once I exceed 50 2MB packs then gc --auto repacks *every
>> single time* it is run. This is unexpected, at least.
>
> There is also a gc.autopacklimit which controls auto-gc'ing based on
> the number of packs.  The default is 50 and it does not consider the
> pack.packSizeLimit setting when deciding whether or not to auto-gc.
> It can be raised, or it can be disabled by setting it to zero.

I disabled it entirely and that seemed to resolve the issue.  Thanks!


-- 
Jon

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-01-06 22:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-06 17:59 gc.auto bug in 1.6.5.7 Jon Nelson
2010-01-06 18:31 ` Brandon Casey
2010-01-06 22:27   ` Jon Nelson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).