From: Jon Nelson <jnelson@jamponi.net>
To: git@vger.kernel.org
Subject: unable to run gc (or git repack -Adl )
Date: Fri, 29 Jan 2010 16:29:01 -0600 [thread overview]
Message-ID: <cccedfc61001291429q7dfa2045x18134439ad1e7c94@mail.gmail.com> (raw)
Using 1.6.4.2 on openSUSE 11.2 (x86_64).
I have a beefy repo (du of 14GB) that I can't seem to run 'gc' on.
After running for over 2 hours, this is what I get:
Counting objects: 267676, done.
Compressing objects: 100% (217424/217424), done.
fatal: Unable to create temporary file: Too many open files
error: failed to run repack
Ugh!
I have 3 GB of memory (and 1GB of swap).
When I strace the various processes, I see some things I don't understand:
1. I see the 'git-repack' shell process scanning for .keep files. I
don't have any. Is there a shortcut to this?
It's also hugely inefficient. In this case, the code to identify non
.keep packs takes *4 minutes, 45 seconds*, lots of disk I/O, and lots
of CPU (it pegs one CPU at 100% for the entire duration). With a wee
bit of awk, I have reduced that to 2.3 seconds with VASTLY reduced I/O
and CPU requirements. Patch attached.
2. When git-pack-objects is being run, around the time it's 85% done
"compressing" it's very very very slow. Like, 2-5 objects every
second. The largest object in the repo is about 1MB.
3. When git pack objects is running and counting up the number of
objects, it is stat'ing files that aren't in the working directly, and
should not be, according to the index. If I switch the repo to be a
"bare" repository, then it doesn't do that, however, why is it doing
that in the first place?
4. Should git-pack-objects be reading the pack.idx files for counting
objects instead of the .pack files themselves?
5. There is no 5
6. Should git-pack-objects be closing .pack files after opening them?
I have 6559 .pack files.
7. Ultimately, how do I get "git gc" to work on this repo?
diff --git a/git-repack.sh b/git-repack.sh
index 1eb3bca..4358f96 100755
--- a/git-repack.sh
+++ b/git-repack.sh
@@ -62,15 +62,7 @@ case ",$all_into_one," in
,t,)
args= existing=
if [ -d "$PACKDIR" ]; then
- for e in `cd "$PACKDIR" && find . -type f -name '*.pack' \
- | sed -e 's/^\.\///' -e 's/\.pack$//'`
- do
- if [ -e "$PACKDIR/$e.keep" ]; then
- : keep
- else
- existing="$existing $e"
- fi
- done
+ existing=$( find . -type f -name '*.pack' -o -name
'*.pack.keep' | sed -e 's/^\.\///' | sort | awk '{ if ($0 ~ /\.keep$/)
{ N=substr($0, 0, length($0)-5); K[N]=0; } else { K[$0]=1; } } END {
for (k in K) { if (K[k] == 1) { printf "%s ", k; } } } ' )
if test -n "$existing" -a -n "$unpack_unreachable" -a \
-n "$remove_redundant"
then
--
Jon
next reply other threads:[~2010-01-29 22:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-29 22:29 Jon Nelson [this message]
2010-01-30 2:14 ` unable to run gc (or git repack -Adl ) Nicolas Pitre
2010-01-30 2:45 ` Jon Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cccedfc61001291429q7dfa2045x18134439ad1e7c94@mail.gmail.com \
--to=jnelson@jamponi.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).