From: Bagas Sanjaya <bagasdotme@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>, git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
Eli Schwartz <eschwartz@archlinux.org>, Jeff King <peff@peff.net>,
Eric Sunshine <sunshine@sunshineco.com>,
Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH] send-email: fix a "first config key wins" regression in v2.33.0
Date: Mon, 6 Sep 2021 18:05:25 +0700 [thread overview]
Message-ID: <ce194f13-2b1f-fb21-e224-80190f3b2fd6@gmail.com> (raw)
In-Reply-To: <patch-1.1-ae6ff9f77f1-20210906T073306Z-avarab@gmail.com>
On 06/09/21 14.33, Ævar Arnfjörð Bjarmason wrote:
> +test_expect_success $PREREQ 'sendemail.8bitEncoding in .git/config overrides --global .gitconfig' '
> + clean_fake_sendmail &&
> + git config sendemail.assume8bitEncoding UTF-8 &&
> + test_when_finished "rm -rf home" &&
> + mkdir home &&
> + git config -f home/.gitconfig sendemail.assume8bitEncoding "bogus too" &&
> + echo bogus |
> + env HOME="$(pwd)/home" DEBUG=1 \
> + git send-email --from=author@example.com --to=nobody@example.com \
> + --smtp-server="$(pwd)/fake.sendmail" \
> + email-using-8bit >stdout &&
> + egrep "Content|MIME" msgtxt1 >actual &&
> + test_cmp content-type-decl actual
> +'
> +
Did you mean overrides global .gitconfig (s/--global/global/)?
Anyway, compiled and tested successfully (test suite passed).
Tested-by: Bagas Sanjaya <bagasdotme@gmail.com>
--
An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2021-09-06 11:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-05 23:01 Regression in git send-email parsing sendemail.* config values Eli Schwartz
2021-09-06 0:04 ` Ævar Arnfjörð Bjarmason
2021-09-06 1:44 ` Eli Schwartz
2021-09-06 7:33 ` [PATCH] send-email: fix a "first config key wins" regression in v2.33.0 Ævar Arnfjörð Bjarmason
2021-09-06 8:32 ` Carlo Arenas
2021-09-06 11:05 ` Bagas Sanjaya [this message]
2021-09-07 9:15 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce194f13-2b1f-fb21-e224-80190f3b2fd6@gmail.com \
--to=bagasdotme@gmail.com \
--cc=avarab@gmail.com \
--cc=eschwartz@archlinux.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).