git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Erez Zilber" <erezzi.list@gmail.com>
To: "Pierre Habouzit" <madcoder@debian.org>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>, open-iscsi@googlegroups.com
Subject: Re: git-describe doesn't show the most recent tag
Date: Sun, 28 Sep 2008 18:05:51 +0300	[thread overview]
Message-ID: <ce513bcc0809280805wb0598b7r8d5e89c1187b080d@mail.gmail.com> (raw)
In-Reply-To: <20080928143949.GH5302@artemis.corp>

On Sun, Sep 28, 2008 at 5:39 PM, Pierre Habouzit <madcoder@debian.org> wrote:
> On Sun, Sep 28, 2008 at 02:29:21PM +0000, Erez Zilber wrote:
>> On Sun, Sep 28, 2008 at 4:55 PM, Pierre Habouzit <madcoder@debian.org> wrote:
>> > On Sun, Sep 28, 2008 at 01:48:42PM +0000, Erez Zilber wrote:
>> >> Why is this happening?
>> >
>> >       --tags
>> >           Instead of using only the annotated tags, use any tag found in
>> >           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> >           .git/refs/tags.
>> >
>>
>> I'm not sure that I understand the difference between tags and annotated tags.
>
>  a lightweight tag is just a reference. an annotated tag has a message
> associated. Usually tags are meant as local help, whereas annotated tags
> are the ones pushed to the repositories and that never change. That's
> why many tools ignore non annotated tags by default unless you pass
> --tags to them.

Thanks for the explanation.

>
>> Anyway, if I move to the master branch, I see the following tags:
>>
>> [erez.zilber@erez-lx:/tmp/open-iscsi.git]$ ls .git/refs/tags/
>> 2.0-868-rc1  2.0-869  2.0-869.1  2.0-869.2  2.0-869-rc2  2.0-869-rc3
>> 2.0-869-rc4  2.0-870-rc1
>> [erez.zilber@erez-lx:/tmp/open-iscsi.git]$ git-tag
>> 2.0-868-rc1
>> 2.0-869
>> 2.0-869-rc2
>> 2.0-869-rc3
>> 2.0-869-rc4
>> 2.0-869.1
>> 2.0-869.2
>> 2.0-870-rc1
>>
>> However:
>> [erez.zilber@erez-lx:/tmp/open-iscsi.git]$ git-describe --tags
>> 2.0-868-rc1-81-g31c9d42
>>
>> I was expecting to see 2.0-870-rc1 here.
>
>  That's because master is not at -rc1 exactly, but some commits
> afterwards. Please read the git-describe manpage fully, it's _really_
> well explained:
>
>       The command finds the most recent tag that is reachable from a commit.
>       If the tag points to the commit, then only the tag is shown. Otherwise,
>       it suffixes the tag name with the number of additional commits on top
>       of the tagged object and the abbreviated object name of the most recent
>       commit.
>
>
> Which means that your master is 81 commits ahead of the exact 2.0-860-rc1 tag,
> at sha1 31c9d42

I read that, but I still don't understand what happens in the open-iscsi tree:

[erez.zilber@erez-lx:/tmp/open-iscsi.git]$ cat .git/refs/tags/2.0-870-rc1
5e80c8167c112687ae7b30b1e40af6f03088c56c

The head is 12 commits from the 2.0-870-rc1 tag. Therefore, I expected
to see something like 2.0-870-rc1-12-some_hash (not
2.0-868-rc1-81-g31c9d42).

Erez

  parent reply	other threads:[~2008-09-28 15:07 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-28 13:48 git-describe doesn't show the most recent tag Erez Zilber
2008-09-28 13:55 ` Pierre Habouzit
2008-09-28 14:29   ` Erez Zilber
2008-09-28 14:39     ` Pierre Habouzit
2008-09-28 15:03       ` Pierre Habouzit
2008-09-28 15:12         ` [PATCH] doc: enhance git describe --tags help Pierre Habouzit
2008-09-29 15:01           ` Shawn O. Pearce
2008-09-30  8:39             ` Pierre Habouzit
2008-10-10 16:59               ` [RFC PATCH] describe: Make --tags and --all match lightweight tags more often Shawn O. Pearce
2008-10-10 17:12                 ` Pierre Habouzit
2008-10-10 18:18                   ` Junio C Hamano
2008-10-13 14:32                     ` Shawn O. Pearce
2008-10-13 14:39                   ` [PATCH v2] " Shawn O. Pearce
2008-10-15 12:54                     ` Santi Béjar
2008-10-11 22:47                 ` [RFC PATCH] " Andreas Ericsson
2008-10-12 18:00                   ` Shawn O. Pearce
2008-10-12 18:13                     ` Andreas Ericsson
2008-10-12 18:29                 ` Uwe Kleine-König
2008-09-30  9:56             ` [PATCH] doc: enhance git describe --tags help Uwe Kleine-König
2008-09-30 10:09               ` Andreas Ericsson
2008-09-30 19:04               ` Shawn O. Pearce
2008-09-30 22:14                 ` Uwe Kleine-König
2008-09-30 22:26                   ` Shawn O. Pearce
2008-10-15 20:05                     ` Uwe Kleine-König
2008-09-28 15:05       ` Erez Zilber [this message]
2008-09-28 14:51     ` git-describe doesn't show the most recent tag Andreas Ericsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce513bcc0809280805wb0598b7r8d5e89c1187b080d@mail.gmail.com \
    --to=erezzi.list@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=madcoder@debian.org \
    --cc=open-iscsi@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).