From: Mark Levedahl <mlevedahl@gmail.com>
To: "Johannes Sixt" <j6t@kdbg.org>,
"Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>,
Patrick Steinhardt <ps@pks.im>,
git@vger.kernel.org
Subject: Re: [PATCH 5/5] git-gui: ensure own version of git-gui--askpass is used
Date: Wed, 30 Jul 2025 17:19:20 -0400 [thread overview]
Message-ID: <cf81b5f5-06a5-404c-9edd-e94b902aa455@gmail.com> (raw)
In-Reply-To: <ce964e5a-fe30-42da-bf8d-969893e3907f@kdbg.org>
On 7/30/25 3:04 PM, Johannes Sixt wrote:
> Am 30.07.25 um 18:40 schrieb Carlo Marcelo Arenas Belón:
>> Propagate the `git --exec-path` that is defined at build time
>> and use it when defining which askpass helper to use by default.
>>
>> This is specially useful in macOS where a broken version of that
>> helper is provided by the system git.
>>
>> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
>> ---
>
The expectation is that git-gui--askpass is colocated with git-gui, and not with git. This
directory is found at runtime as
[file dirname [file normalize $::argv0]]]
It seems to me we could just put this into git-gui.sh instead of [git --exec-path], and
the patch is much simpler.
Mark
next prev parent reply other threads:[~2025-07-30 21:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 16:40 [PATCH 0/5] git-gui: workaround deprecation of Tcl/TK 8.5 in macOS Carlo Marcelo Arenas Belón
2025-07-30 16:40 ` [PATCH 1/5] git-gui: remove uname_O in Makefile Carlo Marcelo Arenas Belón
2025-07-30 20:07 ` Junio C Hamano
2025-07-30 16:40 ` [PATCH 2/5] git-gui: fix dependency of GITGUI_MAIN on generator Carlo Marcelo Arenas Belón
2025-07-30 16:40 ` [PATCH 3/5] git-gui: retire Git Gui.app Carlo Marcelo Arenas Belón
2025-07-30 16:40 ` [PATCH 4/5] git-gui: honor TCLTK_PATH in git-gui--askpass Carlo Marcelo Arenas Belón
2025-07-30 19:02 ` Johannes Sixt
2025-07-31 10:42 ` Patrick Steinhardt
2025-07-30 16:40 ` [PATCH 5/5] git-gui: ensure own version of git-gui--askpass is used Carlo Marcelo Arenas Belón
2025-07-30 19:04 ` Johannes Sixt
2025-07-30 21:19 ` Mark Levedahl [this message]
2025-07-30 19:09 ` [PATCH 0/5] git-gui: workaround deprecation of Tcl/TK 8.5 in macOS Johannes Sixt
2025-07-30 23:54 ` Carlo Arenas
2025-07-31 10:46 ` Patrick Steinhardt
2025-07-30 20:06 ` Junio C Hamano
2025-07-30 20:06 ` Junio C Hamano
2025-07-30 20:51 ` Carlo Arenas
2025-07-31 0:04 ` Junio C Hamano
2025-07-31 8:06 ` [PATCH v2 0/5] git-gui: workaround deprecation of Tcl/Tk " Carlo Marcelo Arenas Belón
2025-07-31 8:06 ` [PATCH v2 1/5] git-gui: remove uname_O in Makefile Carlo Marcelo Arenas Belón
2025-07-31 8:06 ` [PATCH v2 2/5] git-gui: fix dependency of GITGUI_MAIN on generator Carlo Marcelo Arenas Belón
2025-07-31 8:06 ` [PATCH v2 3/5] git-gui: retire Git Gui.app Carlo Marcelo Arenas Belón
2025-07-31 8:06 ` [PATCH v2 4/5] git-gui: honor TCLTK_PATH in git-gui--askpass Carlo Marcelo Arenas Belón
2025-07-31 8:06 ` [PATCH v2 5/5] git-gui: ensure own version of git-gui--askpass is used Carlo Marcelo Arenas Belón
2025-07-31 17:47 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf81b5f5-06a5-404c-9edd-e94b902aa455@gmail.com \
--to=mlevedahl@gmail.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=johannes.schindelin@gmx.de \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).