git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jon Forrest <nobozo@gmail.com>
To: "Jakub Narębski" <jnareb@gmail.com>, git@vger.kernel.org
Subject: Re: [RFC] A Change to Commit IDs Too Ridiculous to Consider?
Date: Sun, 24 Jul 2016 12:20:35 -0700	[thread overview]
Message-ID: <cfff11c9-e212-88a1-c00b-3e7a361e0db9@gmail.com> (raw)
In-Reply-To: <57950D12.2000607@gmail.com>



On 7/24/2016 11:46 AM, Jakub Narębski wrote:
> Please try to keep to the 80-character lines.

Sorry.

> Another possibility is to set authordate and committerdate to some
> specified time by the way of appropriate environment variables.

That sounds like a great idea. Assuming it
works the way I envision, this wouldn't require
any changes to the source code.

> What I think you don't realize is that "commit" objects are not
> treated in any way special. Object identifiers of all objects are
> SHA-1 hash of uncompressed loose representation of said object
> (type + length + contents).

I know this, but I thought that commit object IDs were the only
ones that included a date in what gets run through the SHA-1
hash function. If there are others, then you're right - they'd
need to be included in this proposal.

> Well, you could not record dates in commit object, but I think
> Git considers such objects broken.

You mean that Git could, after the fact, detect commit IDs
that didn't include a date? If this is true, then your
idea of using fixed dates from environment variables
would be the only way to do this.

> IMVHO it would require heavy surgery of Git for little benefit
> (see the beginning of reply for alternate solutions).

Even using your environment variable solution that wouldn't
require any code changes?

Jon


  reply	other threads:[~2016-07-24 19:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-24 18:12 [RFC] A Change to Commit IDs Too Ridiculous to Consider? Jon Forrest
2016-07-24 18:46 ` Jakub Narębski
2016-07-24 19:20   ` Jon Forrest [this message]
2016-07-24 20:42     ` Jakub Narębski
2016-07-25  3:56       ` Jon Forrest
2016-07-24 18:51 ` Rodrigo Campos
2016-07-24 19:57   ` Jon Forrest
2016-07-25 15:03     ` Junio C Hamano
2016-07-25 17:11       ` Junio C Hamano
2016-07-26 14:26     ` Philip Oakley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfff11c9-e212-88a1-c00b-3e7a361e0db9@gmail.com \
    --to=nobozo@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).