git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: [PATCH 0/4] Make unpack_trees() do separate source and destination indexes
Date: Thu, 6 Mar 2008 18:16:27 -0800	[thread overview]
Message-ID: <cover.1204856187.git.torvalds@linux-foundation.org> (raw)

Ok, this goes on top of the five-commit series yesterday.  The first two
patches are pure fixes and cleanups, the third one does a fairly
mechanical thing to get rid of implied usage of "the_index", and the
last one actually splits up the source and destination index handling.

Linus Torvalds (4):
  Fix tree-walking compare_entry() in the presense of --prefix
  Add 'const' where appropriate to index handling functions
  Make 'unpack_trees()' take the index to work on as an argument
  Make 'unpack_trees()' have a separate source and destination index

The nice thing to see is how this clearly removes more lines than it
adds, and the code is a bit more readable too, I think.

 builtin-checkout.c        |    9 +++
 builtin-commit.c          |    2 +
 builtin-merge-recursive.c |    2 +
 builtin-read-tree.c       |   23 +------
 cache.h                   |   10 ++--
 diff-lib.c                |   47 ++-----------
 hash.c                    |    6 +-
 hash.h                    |    4 +-
 read-cache.c              |   12 ++--
 tree-walk.c               |    3 +
 unpack-trees.c            |  158 ++++++++++++++++++++++-----------------------
 unpack-trees.h            |   15 +++--
 12 files changed, 128 insertions(+), 163 deletions(-)


             reply	other threads:[~2008-03-07  2:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-07  2:16 Linus Torvalds [this message]
2008-03-06 20:26 ` [PATCH 3/4] Make 'unpack_trees()' take the index to work on as an argument Linus Torvalds
2008-03-06 20:46 ` [PATCH 2/4] Add 'const' where appropriate to index handling functions Linus Torvalds
2008-03-06 23:44 ` [PATCH 1/4] Fix tree-walking compare_entry() in the presense of --prefix Linus Torvalds
2008-03-07  2:12 ` [PATCH 4/4] Make 'unpack_trees()' have a separate source and destination index Linus Torvalds
2008-03-07 14:13   ` Johannes Schindelin
2008-03-07 17:32     ` Linus Torvalds
2008-03-07 21:11   ` Daniel Barkalow
2008-03-07 21:48     ` Linus Torvalds
2008-03-07  5:45 ` [PATCH 0/4] Make unpack_trees() do separate source and destination indexes Junio C Hamano
2008-03-07 17:46   ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1204856187.git.torvalds@linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).