git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miklos Vajna <vmiklos@frugalware.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Russell King <rmk@arm.linux.org.uk>, git@vger.kernel.org
Subject: [PATCH 0/3] make builtin-commit use commit_tree() and reduce_heads()
Date: Wed, 10 Sep 2008 22:10:30 +0200	[thread overview]
Message-ID: <cover.1221077214.git.vmiklos@frugalware.org> (raw)

Hi,

On Tue, Sep 09, 2008 at 05:52:37PM +0100, Russell King <rmk@arm.linux.org.uk> wrote:
> Is this intentional, or is it a bug?

It is because builtin-commit does not use reduce_heads(), but
builtin-merge does.

Here are 3 patches to make builtin-commit use commit_tree() and
reduce_heads() as well.

The first one just improves the commit_tree() interface.

The second one is a cleanup, but it also adds reduce_heads() usage, to
fix the issue, pointed out by Russell King.

The third one adds new testcases, based on the ones provided by him.

Miklos Vajna (3):
  commit_tree(): add a new author parameter
  builtin-commit: use commit_tree()
  t7603: add new testcases to ensure builtin-commit uses reduce_heads()

 builtin-commit-tree.c         |    9 ++++--
 builtin-commit.c              |   63 +++++++++-------------------------------
 builtin-merge.c               |    4 +-
 builtin.h                     |    3 +-
 t/t7603-merge-reduce-heads.sh |   53 ++++++++++++++++++++++++++++++++++
 5 files changed, 77 insertions(+), 55 deletions(-)

             reply	other threads:[~2008-09-10 20:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-10 20:10 Miklos Vajna [this message]
2008-09-10 20:10 ` [PATCH 1/3] commit_tree(): add a new author parameter Miklos Vajna
2008-09-10 20:10   ` [PATCH 2/3] builtin-commit: use commit_tree() Miklos Vajna
2008-09-10 20:10     ` [PATCH 3/3] t7603: add new testcases to ensure builtin-commit uses reduce_heads() Miklos Vajna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1221077214.git.vmiklos@frugalware.org \
    --to=vmiklos@frugalware.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=rmk@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).