From: Johannes Schindelin <johannes.schindelin@gmx.de>
To: git@vger.kernel.org, gitster@pobox.com
Subject: [PATCH 0/2] submodule path handling fixes
Date: Sat, 7 Feb 2009 14:42:43 +0100 (CET) [thread overview]
Message-ID: <cover.1234013924u.git.johannes.schindelin@gmx.de> (raw)
In-Reply-To: <7vfxiqy76k.fsf@gitster.siamese.dyndns.org>
My earlier attempt at this was misguided by my laziness, and I was willing
to sacrifice correctness for the ability to move on to other problems.
So now, I taught plumbing to handle the trailing slash problem, which is
not only much cleaner, but helps other users of ls-files, too.
Note that at this moment, it is beyond my reach to fix the issue that "git
submodule no-such-submodule" will _only_ warn and not _fail_.
That would take a builtinification, as ls-files is used in a pipe in
git-submodule.sh, and AFAIR there is no really portable way to catch
errors in a pipe, short of using temporary files.
Johannes Schindelin (2):
Let ls-files strip trailing slashes in submodules' paths
submodule: warn about non-submodules
builtin-ls-files.c | 21 ++++++++++++++++++++-
git-submodule.sh | 2 +-
t/t7400-submodule-basic.sh | 13 +++++++++++++
3 files changed, 34 insertions(+), 2 deletions(-)
next prev parent reply other threads:[~2009-02-07 13:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1233892769u.git.johannes.schindelin@gmx.de>
2009-02-06 4:00 ` [PATCH] submodule: handle trailing slash, warn about non-submodules Johannes Schindelin
2009-02-06 5:29 ` Junio C Hamano
2009-02-06 11:41 ` Johannes Schindelin
2009-02-07 8:36 ` Junio C Hamano
2009-02-07 13:42 ` Johannes Schindelin [this message]
2009-02-07 21:45 ` [PATCH 0/2] submodule path handling fixes Junio C Hamano
2009-02-07 13:43 ` [PATCH 1/2] Let ls-files strip trailing slashes in submodules' paths Johannes Schindelin
2009-02-07 13:43 ` [PATCH 2/2] submodule: warn about non-submodules Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1234013924u.git.johannes.schindelin@gmx.de \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).