git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kjetil Barvik <barvik@broadpark.no>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Kjetil Barvik <barvik@broadpark.no>
Subject: [PATCH v4 0/9] git checkout: more cleanups, optimisation, less lstat() calls
Date: Mon, 09 Feb 2009 21:54:03 +0100	[thread overview]
Message-ID: <cover.1234211594.git.barvik@broadpark.no> (raw)

Changes since v3

-- patch 4/9 ---
 - use memcpy() instead of memmove()

-- patch 9/9 ---
 - NOTE/NB: this patch is only a debug patch, not be included in the
   final GIT release version.

OK, sorry that it took a while, but I was investigating why it seems
that patch 1/9 increases the user time.  As it is hard to get the
exact same test results on each run (I guess that "racy git" has
something to say in this case), I think that I should let it go, and
if necessary post a patch later on.

I have not done anything with patch 7/9, since Johannes Sixt wrote:

   "In the case of this patch, the timestamp is queried via the handle
    that made the change, and in this case special case the timestamp
    could be correct nevertheless. The guarantee doesn't cover this
    case, but it would be natural, and perhaps it Just Works?"

So, I let it be up to Johannes to decide if there should be an
"#ifndef FSTAT_UNRELIABLE" test around the fstat() usage inside patch
7/9.


Kjetil Barvik (9):
  lstat_cache(): small cleanup and optimisation
  lstat_cache(): generalise longest_match_lstat_cache()
  lstat_cache(): swap func(length, string) into func(string, length)
  unlink_entry(): introduce schedule_dir_for_removal()
  create_directories(): remove some memcpy() and strchr() calls
  write_entry(): cleanup of some duplicated code
  write_entry(): use fstat() instead of lstat() when file is open
  show_patch_diff(): remove a call to fstat()
  lstat_cache(): print a warning if doing ping-pong between cache types

 Documentation/CodingGuidelines |    3 +
 builtin-add.c                  |    2 +-
 builtin-apply.c                |    2 +-
 builtin-update-index.c         |    2 +-
 cache.h                        |   10 ++-
 combine-diff.c                 |    4 +-
 diff-lib.c                     |    2 +-
 dir.c                          |    2 +-
 entry.c                        |  108 ++++++++++++-------------
 symlinks.c                     |  176 ++++++++++++++++++++++++++++++----------
 unpack-trees.c                 |   34 ++------
 11 files changed, 207 insertions(+), 138 deletions(-)

             reply	other threads:[~2009-02-09 20:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-09 20:54 Kjetil Barvik [this message]
2009-02-09 20:54 ` [PATCH v4 1/9] lstat_cache(): small cleanup and optimisation Kjetil Barvik
2009-02-09 20:54 ` [PATCH v4 2/9] lstat_cache(): generalise longest_match_lstat_cache() Kjetil Barvik
2009-02-09 20:54 ` [PATCH v4 3/9] lstat_cache(): swap func(length, string) into func(string, length) Kjetil Barvik
2009-02-09 20:54 ` [PATCH v4 4/9] unlink_entry(): introduce schedule_dir_for_removal() Kjetil Barvik
2009-02-09 20:54 ` [PATCH v4 5/9] create_directories(): remove some memcpy() and strchr() calls Kjetil Barvik
2009-02-09 20:54 ` [PATCH v4 6/9] write_entry(): cleanup of some duplicated code Kjetil Barvik
2009-02-09 20:54 ` [PATCH v4 7/9] write_entry(): use fstat() instead of lstat() when file is open Kjetil Barvik
2009-02-09 20:54 ` [PATCH v4 8/9] show_patch_diff(): remove a call to fstat() Kjetil Barvik
2009-02-09 20:54 ` [PATCH v4 9/9] lstat_cache(): print a warning if doing ping-pong between cache types Kjetil Barvik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1234211594.git.barvik@broadpark.no \
    --to=barvik@broadpark.no \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).