git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <johannes.schindelin@gmx.de>
To: git@vger.kernel.org, gitster@pobox.com
Cc: Johannes Sixt <j6t@kdbg.org>, Steffen Prohaska <prohaska@zib.de>
Subject: [PATCH 0/2] RUNTIME_PREFIX enhancements
Date: Wed, 18 Feb 2009 16:10:54 +0100 (CET)	[thread overview]
Message-ID: <cover.1234969572u.git.johannes.schindelin@gmx.de> (raw)

When I ran "make" in msysGit's /git/, I was greeted by a pretty unfriendly 
message about a RUNTIME_PREFIX that could not be determined.

Not understanding the code in exec_cmd.c, I went back to a comment I made 
to one of the iterations of the RUNTIME_PREFIX patch series (back when I 
spent a considerable amount of time to understand the code), and turned it 
into a patch myself.

I hope you will agree that the code introduced in 1/2 is more 
understandable than what is removed in 2/2 in favor of the former.

The real meat comes in patch 2/2:

The problem is that Windows will look in the current directory before 
looking in the PATH when it tries to execute a program.  So it will find 
the executable C:\msysgit\git\git.exe and be unable to strip the suffices 
"libexec/git-core" or "bin".

I just added "git" (which should not hurt other users, but instead help 
them if they did not install Git but run it in-place).

Johannes Schindelin (2):
  Introduce the function strip_path_suffix()
  system_path(): simplify using strip_path_suffix(), and add suffix
    "git"

 cache.h    |    2 ++
 exec_cmd.c |   32 +++-----------------------------
 path.c     |   33 +++++++++++++++++++++++++++++++++
 3 files changed, 38 insertions(+), 29 deletions(-)

             reply	other threads:[~2009-02-18 15:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-18 15:10 Johannes Schindelin [this message]
2009-02-18 15:11 ` [PATCH 1/2] Introduce the function strip_path_suffix() Johannes Schindelin
2009-02-18 19:39   ` Johannes Sixt
2009-02-18 21:13     ` Johannes Schindelin
2009-02-18 22:27       ` Johannes Sixt
2009-02-18 23:18         ` Johannes Schindelin
2009-02-19 19:10     ` [PATCH v2 0/2] RUNTIME_PREFIX enhancements Johannes Schindelin
2009-02-19 19:10     ` [PATCH v2 1/2] Introduce the function strip_path_suffix() Johannes Schindelin
2009-02-19 20:12       ` Johannes Schindelin
2009-02-19 20:26       ` Johannes Sixt
2009-02-19 20:44         ` Johannes Schindelin
2009-02-19 19:10     ` [PATCH v2 2/2] system_path(): simplify using strip_path_suffix(), and add suffix "git" Johannes Schindelin
2009-02-19 20:39       ` Johannes Sixt
2009-02-19 20:48         ` Johannes Schindelin
2009-02-20  8:35         ` Junio C Hamano
2009-02-18 15:11 ` [PATCH " Johannes Schindelin
2009-02-18 19:38 ` [PATCH 0/2] RUNTIME_PREFIX enhancements Johannes Sixt
2009-02-18 21:11   ` Johannes Schindelin
2009-02-18 22:52     ` Johannes Sixt
2009-02-18 23:19       ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1234969572u.git.johannes.schindelin@gmx.de \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j6t@kdbg.org \
    --cc=prohaska@zib.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).