From: Thomas Rast <trast@student.ethz.ch>
To: Jef Driesen <jefdriesen@hotmail.com>,
Jef Driesen <jefdriesen@hotmail.com>
Cc: Jeff King <peff@peff.net>, Nanako Shiraishi <nanako3@lavabit.com>,
<git@vger.kernel.org>
Subject: [RFC PATCH 0/5] Pretty formats for reflog data
Date: Mon, 12 Oct 2009 23:06:02 +0200 [thread overview]
Message-ID: <cover.1255380039.git.trast@student.ethz.ch> (raw)
In-Reply-To: <20091012175201.GA10263@coredump.intra.peff.net>
[I forgot to address the list on the first batch, sorry for the spam.]
Jeff King wrote:
> On Mon, Oct 12, 2009 at 05:47:34PM +0200, Jef Driesen wrote:
>
> > Is it possible to make "git stash list" show more than 10 items?
>
> Try "git stash list -30".
>
> Stash listing is internally just "git log -g refs/stash", so you can
> pass any formatting or limiting arguments you want there (see the git
> log documentation for ideas). If no arguments are given, we pass "-10".
This seems fairly arbitrary, doesn't it? My own working theory is
that Nanako put it in because the git-log|sed construct inherently
bars any way to a pager, so it needs to be cut short.
So suppose we could somehow get rid of the |sed... like if we had
--pretty specifiers for the reflog information.
Sadly
git log -g --format="%h %g: %G"
still fails to exactly replicate the reflog format: if the reflog was
cut off during garbage collection, the last entry refers to a no
longer existing commit causing a stray ':' on that line. Oh, well.
It's also still RFC because:
* I don't like the massive code churn in 2/5, maybe someone sees a
better option.
* 5/5 has a pretty lame excuse. I could also just change it in 'git
stash list' to limit the backwards-incompatibility damage, but
that's also a maintenance headache.
Thomas Rast (5):
reflog-walk: refactor the branch@{num} formatting
Introduce new pretty formats %g and %G for reflog information
stash: Use new %g/%G formats instead of sed
stash list: drop the default limit of 10 stashes
stash: change built-in ref to 'stash' instead of 'refs/stash'
archive.c | 2 +-
builtin-branch.c | 3 +-
builtin-checkout.c | 2 +-
builtin-commit.c | 4 +-
builtin-log.c | 2 +-
builtin-merge.c | 2 +-
builtin-rev-list.c | 2 +-
builtin-shortlog.c | 2 +-
builtin-show-branch.c | 2 +-
commit.h | 7 +++-
git-stash.sh | 10 +-----
log-tree.c | 4 +-
pretty.c | 20 +++++++++++--
reflog-walk.c | 72 ++++++++++++++++++++++++++++++++++---------------
reflog-walk.h | 7 +++++
15 files changed, 94 insertions(+), 47 deletions(-)
next prev parent reply other threads:[~2009-10-12 21:14 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-12 15:47 git stash list with more than 10 items? Jef Driesen
2009-10-12 17:52 ` Jeff King
2009-10-12 19:37 ` [PATCH] git-stash documentation: mention default options for 'list' Miklos Vajna
2009-10-12 19:39 ` Jeff King
2009-10-12 21:06 ` Thomas Rast [this message]
2009-10-12 21:06 ` [RFC PATCH 1/5] reflog-walk: refactor the branch@{num} formatting Thomas Rast
2009-10-12 21:06 ` [RFC PATCH 2/5] Introduce new pretty formats %g and %G for reflog information Thomas Rast
2009-10-14 4:59 ` Jeff King
2009-10-14 9:58 ` Thomas Rast
2009-10-14 9:13 ` Junio C Hamano
2009-10-12 21:06 ` [RFC PATCH 3/5] stash: Use new %g/%G formats instead of sed Thomas Rast
2009-10-14 5:00 ` Jeff King
2009-10-12 21:06 ` [RFC PATCH 4/5] stash list: drop the default limit of 10 stashes Thomas Rast
2009-10-14 5:02 ` Jeff King
2009-10-12 21:06 ` [RFC PATCH 5/5] stash: change built-in ref to 'stash' instead of 'refs/stash' Thomas Rast
2009-10-14 5:06 ` Jeff King
2009-10-15 22:41 ` [PATCH v2 0/5] Pretty formats for reflog data Thomas Rast
2009-10-15 22:41 ` [PATCH v2 1/5] Refactor pretty_print_commit arguments into a struct Thomas Rast
2009-10-15 22:41 ` [PATCH v2 2/5] reflog-walk: refactor the branch@{num} formatting Thomas Rast
2009-10-15 22:41 ` [PATCH v2 3/5] Introduce new pretty formats %g[sdD] for reflog information Thomas Rast
2009-10-16 5:32 ` Jeff King
2009-10-16 8:50 ` Thomas Rast
2009-10-16 14:20 ` [PATCH v3 0/5] Pretty formats for reflog data Thomas Rast
2009-10-16 14:20 ` [PATCH v3 1/5] Refactor pretty_print_commit arguments into a struct Thomas Rast
2009-10-17 17:05 ` Junio C Hamano
2009-10-18 18:51 ` Thomas Rast
2009-10-18 22:47 ` Junio C Hamano
2009-10-19 15:48 ` [PATCH v4 0/5] Pretty formats for reflog data Thomas Rast
2009-10-19 15:48 ` [PATCH v4 1/5] Refactor pretty_print_commit arguments into a struct Thomas Rast
2009-10-19 15:48 ` [PATCH v4 2/5] reflog-walk: refactor the branch@{num} formatting Thomas Rast
2009-10-19 15:48 ` [PATCH v4 3/5] Introduce new pretty formats %g[sdD] for reflog information Thomas Rast
2009-10-19 15:48 ` [PATCH v4 4/5] stash list: use new %g formats instead of sed Thomas Rast
2009-10-19 15:48 ` [PATCH v4 5/5] stash list: drop the default limit of 10 stashes Thomas Rast
2009-10-16 14:20 ` [PATCH v3 2/5] reflog-walk: refactor the branch@{num} formatting Thomas Rast
2009-10-16 14:20 ` [PATCH v3 3/5] Introduce new pretty formats %g[sdD] for reflog information Thomas Rast
2009-10-17 14:48 ` [PATCH v3.1 " Thomas Rast
2009-10-17 15:06 ` Jakub Narebski
2009-10-18 7:18 ` Jeff King
2009-10-18 10:34 ` Nanako Shiraishi
2009-10-16 14:20 ` [PATCH v3 4/5] stash list: use new %g formats instead of sed Thomas Rast
2009-10-16 14:20 ` [PATCH v3 5/5] stash list: drop the default limit of 10 stashes Thomas Rast
2009-10-17 0:50 ` [PATCH v3 0/5] Pretty formats for reflog data Junio C Hamano
2009-10-17 1:18 ` Jeff King
2009-10-15 22:41 ` [PATCH v2 4/5] stash list: use new %g formats instead of sed Thomas Rast
2009-10-15 22:41 ` [PATCH v2 5/5] stash list: drop the default limit of 10 stashes Thomas Rast
2009-10-16 5:20 ` [PATCH v2 0/5] Pretty formats for reflog data Jeff King
2009-10-16 9:00 ` Jakub Narebski
2009-10-12 21:37 ` [RFC PATCH " Jeff King
2009-10-12 21:52 ` Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1255380039.git.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git@vger.kernel.org \
--cc=jefdriesen@hotmail.com \
--cc=nanako3@lavabit.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).