git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Haggerty <mhagger@alum.mit.edu>
To: git@vger.kernel.org
Cc: gitster@pobox.com, Johannes.Schindelin@gmx.de,
	tarmigan+git@gmail.com, j.sixt@viscovery.net,
	Michael Haggerty <mhagger@alum.mit.edu>
Subject: [PATCH 0/3] Fixes to mh/rebase-fixup
Date: Fri, 22 Jan 2010 10:22:28 +0100	[thread overview]
Message-ID: <cover.1264151435.git.mhagger@alum.mit.edu> (raw)

This patch series contains fixes to the mh/rebase-fixup patch series
as suggested by reviewers on the mailing list.

Since the mh/rebase-fixup patch series is already in "next", I have
written these fixup patches against "next".  I hope that is OK.

The third patch removes the attempt to use one-shot export of
variables in do_with_author(), as the "$@" command that it calls might
be a shell function.  This issue was discussed on the mailing list
[1].  This change has the side effect that the GIT_AUTHOR_* variables
remain exported after do_with_author() returns, but I don't think that
this is a problem in the context of git-rebase--interactive.sh.
However, additional review would be welcome here.

[1] http://marc.info/?l=git&m=126345851831751&w=2

Michael Haggerty (3):
  rebase -i: Avoid non-portable "test X -a Y"
  rebase -i: Enclose sed command substitution in quotes
  rebase -i: Export GIT_AUTHOR_* variables explicitly

 git-rebase--interactive.sh |    6 ++----
 t/lib-rebase.sh            |    2 +-
 2 files changed, 3 insertions(+), 5 deletions(-)

             reply	other threads:[~2010-01-22  9:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-22  9:22 Michael Haggerty [this message]
2010-01-22  9:22 ` [PATCH 1/3] rebase -i: Avoid non-portable "test X -a Y" Michael Haggerty
2010-01-22  9:22 ` [PATCH 2/3] rebase -i: Enclose sed command substitution in quotes Michael Haggerty
2010-01-22  9:22 ` [PATCH 3/3] rebase -i: Export GIT_AUTHOR_* variables explicitly Michael Haggerty
2010-01-22 11:16   ` Johannes Schindelin
2010-01-22 21:09     ` Junio C Hamano
2010-01-24  5:33       ` Michael Haggerty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1264151435.git.mhagger@alum.mit.edu \
    --to=mhagger@alum.mit.edu \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j.sixt@viscovery.net \
    --cc=tarmigan+git@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).