git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Webb <chris@arachsys.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: [PATCH 0/6] Add tab-in-indent whitespace rule
Date: Sat, 3 Apr 2010 00:36:50 +0100	[thread overview]
Message-ID: <cover.1270250437.git.chris@arachsys.com> (raw)

This patch set introduces a new whitespace error/fix class for projects and
languages with a coding style where no tab character is used to indent the
lines.

To implement this feature, we need to rework ws_fix_copy() to append to a
strbuf rather than write into a fixed-size output buffer, because tabs may
be expanded into multiple spaces when tab-in-indent is applied. We also have
to change the "catch all errors known to git" to exclude tab-in-indent,
which directly conflicts with the existing indent-with-non-tab rule.


Junio C Hamano (1):
  whitespace: we cannot "catch all errors known to git" anymore

Chris Webb (5):
  whitespace: add tab-in-indent error class
  whitespace: tests for git-diff --check with tab-in-indent error class
  whitespace: replumb ws_fix_copy to take a strbuf *dst instead of char *dst
  whitespace: add tab-in-indent support for --whitespace=fix
  whitespace: tests for git-apply --whitespace=fix with tab-in-indent

 Documentation/config.txt   |    2 +
 builtin/apply.c            |   81 +++++++++++++++++++++-----------------------
 cache.h                    |    3 +-
 t/t4015-diff-whitespace.sh |   42 +++++++++++++++++++++++
 t/t4124-apply-ws-rule.sh   |   53 ++++++++++++++++-------------
 ws.c                       |   73 ++++++++++++++++++++++++++++-----------
 6 files changed, 166 insertions(+), 88 deletions(-)

             reply	other threads:[~2010-04-02 23:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-02 23:36 Chris Webb [this message]
2010-04-02 23:37 ` [PATCH 1/6] whitespace: we cannot "catch all errors known to git" anymore Chris Webb
2010-04-02 23:37 ` [PATCH 2/6] whitespace: add tab-in-indent error class Chris Webb
2010-04-03 10:02   ` Martin Mares
2010-04-02 23:37 ` [PATCH 3/6] whitespace: tests for git-diff --check with " Chris Webb
2010-04-02 23:37 ` [PATCH 4/6] whitespace: replumb ws_fix_copy to take a strbuf *dst instead of char *dst Chris Webb
2010-04-02 23:37 ` [PATCH 5/6] whitespace: add tab-in-indent support for --whitespace=fix Chris Webb
2010-04-02 23:37 ` [PATCH 6/6] whitespace: tests for git-apply --whitespace=fix with tab-in-indent Chris Webb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1270250437.git.chris@arachsys.com \
    --to=chris@arachsys.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).