From: Michael J Gruber <git@drmicha.warpmail.net>
To: git@vger.kernel.org
Subject: [PATCH 0/4] Don't warn about missing EOL for symlinks
Date: Thu, 3 Jun 2010 16:35:19 +0200 [thread overview]
Message-ID: <cover.1275575236.git.git@drmicha.warpmail.net> (raw)
"No newline at end of file" always confuses me when looking at a diff for
symlinks. "File? Huh? Didn't Git recognize my symlink?"
This mini series refactors the diff/xdiff code slightly to have the two
occurences of the warning both in diff.c, introduces a whitespace flag
WS_NO_EOL_AT_EOF to make this warning configurable, and actually changes
the default behaviour to what is described thorougly along with the
rationale in 3/4.
4/4 is a RFC - do we need to tweak this from config like other whitespace
warnings? 4/4 is lacking the Doc change for now.
Michael J Gruber (4):
diff/xdiff: refactor EOF-EOL detection
diff: make treatment of missing EOL at EOF configurable
diff: Do not warn about missing EOL at EOF for symlinks
RFC: add whitespace rule for no-eol-at-eof
cache.h | 3 ++-
diff.c | 7 ++++++-
t/t4030-diff-textconv.sh | 1 -
ws.c | 1 +
xdiff/xutils.c | 5 -----
5 files changed, 9 insertions(+), 8 deletions(-)
next reply other threads:[~2010-06-03 14:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 14:35 Michael J Gruber [this message]
2010-06-03 14:35 ` [PATCH 1/4] diff/xdiff: refactor EOF-EOL detection Michael J Gruber
2010-06-03 21:58 ` Junio C Hamano
2010-06-04 7:38 ` Michael J Gruber
2010-06-05 6:38 ` Junio C Hamano
2010-06-05 18:58 ` Michael J Gruber
2010-06-06 22:03 ` Jeff King
2010-06-06 4:00 ` Junio C Hamano
2010-06-06 9:01 ` Johannes Sixt
2010-06-06 22:08 ` Jeff King
2010-06-07 8:10 ` Michael J Gruber
2010-06-03 14:35 ` [PATCH 2/4] diff: make treatment of missing EOL at EOF configurable Michael J Gruber
2010-06-03 14:35 ` [PATCH 3/4] diff: Do not warn about missing EOL at EOF for symlinks Michael J Gruber
2010-06-03 17:02 ` Jeff King
2010-06-03 14:35 ` [PATCH 4/4] RFC: add whitespace rule for no-eol-at-eof Michael J Gruber
2010-06-03 14:47 ` [PATCH 0/4] Don't warn about missing EOL for symlinks Matthieu Moy
2010-06-03 14:57 ` Michael J Gruber
2010-06-03 17:07 ` Jeff King
2010-06-03 19:55 ` Michael J Gruber
2010-06-03 20:17 ` Jeff King
2010-06-04 14:15 ` Johannes Sixt
2010-06-04 15:25 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1275575236.git.git@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).