From: Johannes Schindelin <johannes.schindelin@gmx.de>
To: git@vger.kernel.org
Cc: gitster@pobox.com
Subject: [PATCH 0/2] Fix issues found by gcc 4.6.0
Date: Tue, 22 Mar 2011 13:49:56 +0100 (CET) [thread overview]
Message-ID: <cover.1300798069.git.johannes.schindelin@gmx.de> (raw)
In general, our sources are quite clean. However, a few variables were
unused. Previous gcc version did not find them because they were assigned
values, but those values were never used nontheless.
The tricky question is whether 2/2 really fixes an issue or not.
Unfortunately, my time is too limited to go into detail, but I figured
it'd be better to raise the issue than to remain silent.
Johannes Schindelin (2):
Remove unused variables
Actually use retval
builtin/fsck.c | 3 +--
builtin/remote-ext.c | 4 ----
diff.c | 3 +--
merge-recursive.c | 4 ----
reachable.c | 5 -----
test-subprocess.c | 3 +--
transport-helper.c | 3 +--
tree-diff.c | 2 +-
8 files changed, 5 insertions(+), 22 deletions(-)
--
1.7.4.msysgit.0.167.ge91fd
next reply other threads:[~2011-03-22 12:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-22 12:49 Johannes Schindelin [this message]
2011-03-22 12:50 ` [PATCH 1/2] Remove unused variables Johannes Schindelin
2011-03-22 18:15 ` Junio C Hamano
2011-03-22 18:42 ` Johannes Schindelin
2011-03-22 19:43 ` Jonathan Nieder
2011-03-22 12:50 ` [PATCH 2/2] Actually use retval Johannes Schindelin
2011-03-22 18:10 ` Junio C Hamano
2011-03-22 18:20 ` Johannes Schindelin
2011-03-23 1:26 ` [PATCH 0/2] " Jonathan Nieder
2011-03-23 1:28 ` [PATCH 1/2] tree-diff: make diff_tree return void Jonathan Nieder
2011-03-23 1:30 ` [PATCH 2/2] tree-diff: make diff_tree_sha1 " Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1300798069.git.johannes.schindelin@gmx.de \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).