From: Thomas Rast <trast@student.ethz.ch>
To: <git@vger.kernel.org>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Bo Yang" <struggleyb.nku@gmail.com>,
"Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>,
"Will Palmer" <wmpalmer@gmail.com>
Subject: [PATCH v9 0/5] git log -L
Date: Thu, 21 Mar 2013 13:52:35 +0100 [thread overview]
Message-ID: <cover.1363865444.git.trast@student.ethz.ch> (raw)
Compared to the previous round at
http://thread.gmane.org/gmane.comp.version-control.git/217236
I made the following changes (numbers from v8):
[1/5] Refactor parse_loc
Based on Junio's suggestions, the refactoring is now to a new file
line-range.c that line-log.c will later use. (It still irks me too
much to call straight into builtin/blame.c.)
I also re-copied the existing functions, to make sure that they are
the same. Junio correctly spotted some differences, and since we
claim to only refactor those are bad.
[2/5] Export rewrite_parents() for 'log -L'
Unchanged.
[2.5/5] blame: introduce $ as "end of file" in -L syntax
Dropped. As Junio remarked, omitting the end is already a valid way
of saying the same.
[3/5] Implement line-history search (git log -L)
Integrated Ramsay's fixes and Junio's remarks. Also made some minor
cleanups. Added a perf test.
[4/5] log -L: :pattern:file syntax to find by funcname
Adjusted for changes in the earlier patches; otherwise the same.
[5/5] Speed up log -L... -M
Added to this series, I posted the same patch earlier in the side
thread about the bad performance. The perf test from 4/5 neatly
shows the difference.
Bo Yang (2):
Refactor parse_loc
Export rewrite_parents() for 'log -L'
Thomas Rast (3):
Implement line-history search (git log -L)
log -L: :pattern:file syntax to find by funcname
Speed up log -L... -M
Documentation/blame-options.txt | 21 +-
Documentation/git-blame.txt | 6 +-
Documentation/git-log.txt | 23 +
Documentation/line-range-format.txt | 25 +
Makefile | 4 +
builtin/blame.c | 99 +--
builtin/log.c | 31 +
line-log.c | 1228 +++++++++++++++++++++++++++++++++++
line-log.h | 49 ++
line-range.c | 237 +++++++
line-range.h | 36 +
log-tree.c | 4 +
revision.c | 22 +-
revision.h | 16 +-
t/perf/p4211-line-log.sh | 34 +
t/t4211-line-log.sh | 40 ++
t/t4211/expect.beginning-of-file | 43 ++
t/t4211/expect.end-of-file | 62 ++
t/t4211/expect.move-support-f | 40 ++
t/t4211/expect.simple-f | 59 ++
t/t4211/expect.simple-main | 68 ++
t/t4211/expect.two-ranges | 102 +++
t/t4211/expect.vanishes-early | 39 ++
t/t4211/history.export | 330 ++++++++++
t/t8003-blame-corner-cases.sh | 6 +
25 files changed, 2501 insertions(+), 123 deletions(-)
create mode 100644 Documentation/line-range-format.txt
create mode 100644 line-log.c
create mode 100644 line-log.h
create mode 100644 line-range.c
create mode 100644 line-range.h
create mode 100755 t/perf/p4211-line-log.sh
create mode 100755 t/t4211-line-log.sh
create mode 100644 t/t4211/expect.beginning-of-file
create mode 100644 t/t4211/expect.end-of-file
create mode 100644 t/t4211/expect.move-support-f
create mode 100644 t/t4211/expect.simple-f
create mode 100644 t/t4211/expect.simple-main
create mode 100644 t/t4211/expect.two-ranges
create mode 100644 t/t4211/expect.vanishes-early
create mode 100644 t/t4211/history.export
--
1.8.2.241.gee8bb87
next reply other threads:[~2013-03-21 12:53 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 12:52 Thomas Rast [this message]
2013-03-21 12:52 ` [PATCH v9 1/5] Refactor parse_loc Thomas Rast
2013-03-21 12:52 ` [PATCH v9 2/5] Export rewrite_parents() for 'log -L' Thomas Rast
2013-03-21 12:52 ` [PATCH v9 3/5] Implement line-history search (git log -L) Thomas Rast
2013-03-21 19:05 ` Junio C Hamano
2013-03-23 6:00 ` Thomas Rast
2013-03-21 12:52 ` [PATCH v9 4/5] log -L: :pattern:file syntax to find by funcname Thomas Rast
2013-03-21 12:52 ` [PATCH v9 5/5] Speed up log -L... -M Thomas Rast
2013-03-21 21:11 ` Eric Sunshine
2013-03-23 5:58 ` Thomas Rast
2013-03-23 9:04 ` Jeff King
2013-03-24 7:38 ` Eric Sunshine
2013-03-23 6:44 ` [PATCH v9a 0/5] git log -L Thomas Rast
2013-03-23 6:44 ` [PATCH v9a 1/5] Refactor parse_loc Thomas Rast
2013-03-23 6:44 ` [PATCH v9a 2/5] Export rewrite_parents() for 'log -L' Thomas Rast
2013-03-23 6:44 ` [PATCH v9a 3/5] Implement line-history search (git log -L) Thomas Rast
2013-03-23 10:31 ` Antoine Pelisse
2013-03-23 10:32 ` Antoine Pelisse
2013-03-28 16:47 ` [PATCH v10 0/5] git log -L Thomas Rast
2013-03-28 16:47 ` [PATCH v10 1/5] Refactor parse_loc Thomas Rast
2013-03-28 16:47 ` [PATCH v10 2/5] Export rewrite_parents() for 'log -L' Thomas Rast
2013-03-28 16:47 ` [PATCH v10 3/5] Implement line-history search (git log -L) Thomas Rast
2013-03-28 16:47 ` [PATCH v10 4/5] log -L: :pattern:file syntax to find by funcname Thomas Rast
2013-03-28 16:47 ` [PATCH v10 5/5] Speed up log -L... -M Thomas Rast
2013-03-23 6:44 ` [PATCH v9a 4/5] log -L: :pattern:file syntax to find by funcname Thomas Rast
2013-03-23 6:44 ` [PATCH v9a 5/5] Speed up log -L... -M Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1363865444.git.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=struggleyb.nku@gmail.com \
--cc=wmpalmer@gmail.com \
--cc=zbyszek@in.waw.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).