From: John Keeping <john@keeping.me.uk>
To: git@vger.kernel.org
Cc: Sverre Rabbelier <srabbelier@gmail.com>,
Jonathan Nieder <jrnieder@gmail.com>,
Florian Achleitner <florian.achleitner.2.6.31@gmail.com>,
John Keeping <john@keeping.me.uk>
Subject: [PATCH 0/3] Handle signed tags with 'export' remote helpers
Date: Sun, 14 Apr 2013 11:57:05 +0100 [thread overview]
Message-ID: <cover.1365936811.git.john@keeping.me.uk> (raw)
In-Reply-To: <CAGdFq_g+kk-Fy1fcV6D5x4kroRXX63T8wjKNUqqfu39wUkSO6A@mail.gmail.com>
On Sun, Apr 07, 2013 at 05:02:48PM -0700, Sverre Rabbelier wrote:
> On Sun, Apr 7, 2013 at 2:46 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> > The remote helper infrastructure is certainly being unhelpful here. I
> > wonder if transport-helper should just pass --signed-tag=strip and be
> > done with it (leaving open the possibility of a capability to switch
> > to --signed-tag=verbatim when someone wants to teach the testgit
> > helper to support that). What do you think?
>
> I think that's (at least for now) the right thing to do. Passing
> anything but signed-tag=strip should be triggered by a capability from
> the helper, since most helpers won't know how to deal with signed
> tags.
I don't like the idea of silently stripping tags, so how about this?
Patch 1 adds a new 'warn-strip' mode to 'fast-export --signed-tags=...'
which strips tags but issues a warning when doing so. Then we make
transport-helper use that before finally adding a new capability to
allow a remote helper to change '--signed-tags=warn-strip' into
'--signed-tags=verbatim'.
John Keeping (3):
fast-export: add --signed-tags=warn-strip mode
transport-helper: pass --signed-tags=warn-strip to fast-export
transport-helper: add 'signed-tags' capability
Documentation/git-fast-export.txt | 10 ++++++----
Documentation/gitremote-helpers.txt | 4 ++++
builtin/fast-export.c | 8 +++++++-
git-remote-testgit | 1 +
t/t5801-remote-helpers.sh | 20 ++++++++++++++++++++
t/t9350-fast-export.sh | 6 ++++++
transport-helper.c | 7 ++++++-
7 files changed, 50 insertions(+), 6 deletions(-)
--
1.8.2.694.ga76e9c3.dirty
next prev parent reply other threads:[~2013-04-14 10:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-07 10:34 Remote helpers and signed tags John Keeping
2013-04-07 21:46 ` Jonathan Nieder
2013-04-08 0:02 ` Sverre Rabbelier
2013-04-14 10:57 ` John Keeping [this message]
2013-04-14 10:57 ` [PATCH 1/3] fast-export: add --signed-tags=warn-strip mode John Keeping
2013-04-16 4:09 ` Sverre Rabbelier
2013-04-16 4:47 ` Junio C Hamano
2013-04-16 4:50 ` Sverre Rabbelier
2013-04-16 8:42 ` John Keeping
2013-04-17 4:48 ` Junio C Hamano
2013-04-17 5:02 ` Sverre Rabbelier
2013-04-16 5:32 ` Jonathan Nieder
2013-04-14 10:57 ` [PATCH 2/3] transport-helper: pass --signed-tags=warn-strip to fast-export John Keeping
2013-04-14 10:57 ` [PATCH 3/3] transport-helper: add 'signed-tags' capability John Keeping
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1365936811.git.john@keeping.me.uk \
--to=john@keeping.me.uk \
--cc=florian.achleitner.2.6.31@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).