From: Jiang Xin <worldhello.net@gmail.com>
To: Junio C Hamano <gitster@pobox.com>,
Eric Sunshine <sunshine@sunshineco.com>,
Matthieu Moy <Matthieu.Moy@imag.fr>,
Git List <git@vger.kernel.org>
Cc: Jiang Xin <worldhello.net@gmail.com>
Subject: [PATCH v10 00/14] interactive git-clean
Date: Thu, 16 May 2013 17:53:31 +0800 [thread overview]
Message-ID: <cover.1368696028.git.worldhello.net@gmail.com> (raw)
Updates since v9:
* Patch 01-04: refactor relative_path() in path.c, and reused it in
quote.c and clean.c.
* Patch 14: add testcases as t7301, and catch two bugs by running
testcases.
* Bugfix: when select by number, range like "5-" does not select
last entry.
@@ -485,7 +443,7 @@ static int parse_choice(struct menu_stuff *menu_stuff,
bottom = atoi((*ptr)->buf);
/* a range can be specified like 5-7 or 5- */
if (!*(strchr((*ptr)->buf, '-') + 1)) {
- top = menu_stuff->nr - 1;
+ top = menu_stuff->nr;
} else {
top = atoi(strchr((*ptr)->buf, '-') + 1);
}
* For the "ask each" action, confirmation other than "yes" should not
delete files.
@@ -772,7 +730,7 @@ static int ask_each_cmd(void)
eof = 1;
}
}
- if (!confirm.len || !strncasecmp(confirm.buf, "no", confirm.len)) {
+ if (!confirm.len || strncasecmp(confirm.buf, "yes", confirm.len)) {
*item->string = '\0';
changed++;
}
Jiang Xin (14):
path.c: refactor relative_path(), not only strip prefix
quote.c: remove path_relative, use relative_path instead
Refactor quote_path_relative, remove unused params
Refactor write_name_quoted_relative, remove unused params
git-clean: refactor git-clean into two phases
git-clean: add support for -i/--interactive
git-clean: show items of del_list in columns
git-clean: add colors to interactive git-clean
git-clean: use a git-add-interactive compatible UI
git-clean: add filter by pattern interactive action
git-clean: add select by numbers interactive action
git-clean: add ask each interactive action
git-clean: add documentation for interactive git-clean
test: add t7301 for git-clean--interactive
Documentation/config.txt | 21 +-
Documentation/git-clean.txt | 71 +++-
builtin/clean.c | 771 +++++++++++++++++++++++++++++++++++++++++--
builtin/grep.c | 5 +-
builtin/ls-files.c | 16 +-
cache.h | 2 +-
path.c | 112 +++++--
quote.c | 65 +---
quote.h | 7 +-
setup.c | 5 +-
t/t7301-clean-interactive.sh | 439 ++++++++++++++++++++++++
wt-status.c | 17 +-
12 files changed, 1380 insertions(+), 151 deletions(-)
create mode 100755 t/t7301-clean-interactive.sh
--
1.8.3.rc1.407.g762149a
next reply other threads:[~2013-05-16 9:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 9:53 Jiang Xin [this message]
2013-05-16 9:53 ` [PATCH v10 01/14] path.c: refactor relative_path(), not only strip prefix Jiang Xin
2013-05-16 9:53 ` [PATCH v10 02/14] quote.c: remove path_relative, use relative_path instead Jiang Xin
2013-05-16 9:53 ` [PATCH v10 03/14] Refactor quote_path_relative, remove unused params Jiang Xin
2013-05-16 9:53 ` [PATCH v10 04/14] Refactor write_name_quoted_relative, " Jiang Xin
2013-05-16 19:15 ` Junio C Hamano
2013-05-16 9:53 ` [PATCH v10 05/14] git-clean: refactor git-clean into two phases Jiang Xin
2013-05-16 9:53 ` [PATCH v10 06/14] git-clean: add support for -i/--interactive Jiang Xin
2013-05-16 9:53 ` [PATCH v10 07/14] git-clean: show items of del_list in columns Jiang Xin
2013-05-16 9:53 ` [PATCH v10 08/14] git-clean: add colors to interactive git-clean Jiang Xin
2013-05-16 9:53 ` [PATCH v10 09/14] git-clean: use a git-add-interactive compatible UI Jiang Xin
2013-05-16 19:29 ` Junio C Hamano
2013-05-16 19:39 ` Junio C Hamano
2013-05-16 9:53 ` [PATCH v10 10/14] git-clean: add filter by pattern interactive action Jiang Xin
2013-05-16 9:53 ` [PATCH v10 11/14] git-clean: add select by numbers " Jiang Xin
2013-05-16 9:53 ` [PATCH v10 12/14] git-clean: add ask each " Jiang Xin
2013-05-16 9:53 ` [PATCH v10 13/14] git-clean: add documentation for interactive git-clean Jiang Xin
2013-05-16 9:53 ` [PATCH v10 14/14] test: add t7301 for git-clean--interactive Jiang Xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1368696028.git.worldhello.net@gmail.com \
--to=worldhello.net@gmail.com \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).