git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeremiah Mahler <jmmahler@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jeremiah Mahler <jmmahler@gmail.com>
Subject: [PATCH v9 0/2] format-patch --signature-file=<file>
Date: Fri, 23 May 2014 21:08:12 -0700	[thread overview]
Message-ID: <cover.1400904004.git.jmmahler@gmail.com> (raw)

v9 of patch to add format-patch --signature-file <file> option.

This revision includes more suggestions from Junio C Hamano.

  - Reworded patch description.  Using "special characters" is
	not a feature of this patch.

  - Changed patch description to follow gitcli(7) guidlines.
    "--signature-file=name" instead of "--signature-file name"

  - Reduced set of crucial test cases.

    --signature-file works

    format.signaturefile works

    --no-signature suppresses format.signaturefile

    --signature-file overrides format.signaturefile

    --signature overrides format.signaturefile

  - Note, the control logic had to be re-worked to satisfy these test cases.


Jeff King (1):
  format-patch: make newline after signature conditional

Jeremiah Mahler (1):
  format-patch --signature-file=<file>

 Documentation/config.txt           |  4 +++
 Documentation/git-format-patch.txt |  4 +++
 builtin/log.c                      | 26 ++++++++++++++--
 t/t4014-format-patch.sh            | 61 ++++++++++++++++++++++++++++++++++++++
 4 files changed, 93 insertions(+), 2 deletions(-)

-- 
Jeremiah Mahler
jmmahler@gmail.com
http://github.com/jmahler

             reply	other threads:[~2014-05-24  4:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-24  4:08 Jeremiah Mahler [this message]
2014-05-24  4:08 ` [PATCH v9 1/2] format-patch: make newline after signature conditional Jeremiah Mahler
2014-05-24  4:08 ` [PATCH v9 2/2] format-patch --signature-file=<file> Jeremiah Mahler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1400904004.git.jmmahler@gmail.com \
    --to=jmmahler@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).