From: Jeremiah Mahler <jmmahler@gmail.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Michael Haggerty <mhagger@alum.mit.edu>,
git@vger.kernel.org, Jeremiah Mahler <jmmahler@gmail.com>
Subject: [PATCH v3 0/2] add strbuf_set operations
Date: Thu, 12 Jun 2014 00:29:32 -0700 [thread overview]
Message-ID: <cover.1402557437.git.jmmahler@gmail.com> (raw)
Addition of strbuf_set operations, version 3.
Includes suggestions from Eric Sunshine [1]:
- Revise log message to better argue why this patch is worthwhile.
- Avoid documentation redundancy: "Setting buffer", "Replace buffer".
- Remove unnecessary changes which didn't have a significant benefit
to avoid unnecessary "code churn". builtin/remote.c was the one
file which showed a significant benefit. Others with negligible
benefits have been left as is.
The possible performance improvements using a strbuf_grow_to() operation
as suggested by Michael Haggerty [2] has been left for a later patch.
[1]: http://marc.info/?l=git&m=140247618416057&w=2
[2]: http://marc.info/?l=git&m=140248834420244&w=2
Jeremiah Mahler (2):
add strbuf_set operations
builtin/remote: improve readability via strbuf_set()
Documentation/technical/api-strbuf.txt | 18 ++++++++++
builtin/remote.c | 63 +++++++++++++---------------------
strbuf.c | 21 ++++++++++++
strbuf.h | 13 +++++++
4 files changed, 75 insertions(+), 40 deletions(-)
--
2.0.0
next reply other threads:[~2014-06-12 7:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 7:29 Jeremiah Mahler [this message]
2014-06-12 7:29 ` [PATCH v3 1/2] add strbuf_set operations Jeremiah Mahler
2014-06-12 8:11 ` Thomas Braun
2014-06-12 8:22 ` Jeremiah Mahler
2014-06-12 18:51 ` Junio C Hamano
2014-06-12 19:36 ` Jeremiah Mahler
2014-06-12 21:18 ` Eric Sunshine
2014-06-12 23:14 ` Jeremiah Mahler
2014-06-12 18:50 ` Junio C Hamano
2014-06-12 19:31 ` Jeremiah Mahler
2014-06-12 21:48 ` Eric Sunshine
2014-06-12 23:46 ` Jeremiah Mahler
2014-06-13 7:15 ` Jeff King
2014-06-14 4:49 ` Jeremiah Mahler
2014-06-12 7:29 ` [PATCH v3 2/2] builtin/remote: improve readability via strbuf_set() Jeremiah Mahler
2014-06-12 8:19 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1402557437.git.jmmahler@gmail.com \
--to=jmmahler@gmail.com \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).