From: Jeremiah Mahler <jmmahler@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, Jeremiah Mahler <jmmahler@gmail.com>
Subject: [PATCH v2 0/3] add strnncmp() function
Date: Tue, 17 Jun 2014 00:34:36 -0700 [thread overview]
Message-ID: <cover.1402990051.git.jmmahler@gmail.com> (raw)
Add a strnncmp() function which behaves like strncmp() except it takes
the length of both strings instead of just one.
Then simplify tree-walk.c and unpack-trees.c using this new function.
Replace all occurrences of name_compare() with strnncmp(). Remove
name_compare(), which they both had identical copies of.
Version 2 includes suggestions from Jonathan Neider [1]:
- Fix the logic which caused the new strnncmp() to behave differently
from the old version. Now it is identical to strncmp().
- Improve description of strnncmp().
Also, strnncmp() was switched from using memcmp() to strncmp()
internally to make it clear that this is meant for strings, not
general buffers.
[1]: http://marc.info/?l=git&m=140294981320743&w=2
Jeremiah Mahler (3):
add strnncmp() function
tree-walk: simplify via strnncmp()
unpack-trees: simplify via strnncmp()
strbuf.c | 9 +++++++++
strbuf.h | 2 ++
tree-walk.c | 16 +++-------------
unpack-trees.c | 13 +------------
4 files changed, 15 insertions(+), 25 deletions(-)
--
2.0.0.695.g38ee9a9
next reply other threads:[~2014-06-17 7:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 7:34 Jeremiah Mahler [this message]
2014-06-17 7:34 ` [PATCH v2 1/3] add strnncmp() function Jeremiah Mahler
2014-06-17 8:23 ` Torsten Bögershausen
2014-06-17 15:48 ` Jeremiah Mahler
2014-06-17 9:09 ` Erik Faye-Lund
2014-06-17 15:49 ` Jeremiah Mahler
2014-06-17 17:55 ` Junio C Hamano
2014-06-17 19:27 ` Jeremiah Mahler
2014-06-17 7:34 ` [PATCH v2 2/3] tree-walk: simplify via strnncmp() Jeremiah Mahler
2014-06-17 7:34 ` [PATCH v2 3/3] unpack-trees: " Jeremiah Mahler
2014-06-17 11:08 ` [PATCH v2 0/3] add strnncmp() function Torsten Bögershausen
2014-06-17 15:49 ` Jeremiah Mahler
2014-06-17 17:48 ` Jonathan Nieder
2014-06-17 19:09 ` Jeremiah Mahler
2014-06-18 10:33 ` Ondřej Bílka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1402990051.git.jmmahler@gmail.com \
--to=jmmahler@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).