git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>,
	David Turner <dturner@twopensource.com>
Cc: "Ramsay Jones" <ramsay@ramsayjones.plus.com>,
	"Eric Sunshine" <sunshine@sunshineco.com>,
	"Jeff King" <peff@peff.net>,
	"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
	git@vger.kernel.org, "Michael Haggerty" <mhagger@alum.mit.edu>
Subject: [PATCH v3 00/13] Reference iterators
Date: Sat, 18 Jun 2016 06:15:06 +0200	[thread overview]
Message-ID: <cover.1466222921.git.mhagger@alum.mit.edu> (raw)

This is the reroll of branch mh/ref-iterators promised and discussed
earlier [1]. There are no showstoppers here, but it would be
preferable to merge this version rather than v2.

This version squashes in Ramsay's patch [2], addresses Eric's
comments, and incorporates the whitespace fix that you made when
incorporating v2.

List of changes relative to v2:

* In "refs: introduce an iterator interface":

  * Make two vtables private.

  * Add a whitespace fix from Junio's mh/ref-iterators.

* In "dir_iterator: new API for iterating over a directory tree":

  * Add and improve some comments and docstrings.

  * Fix some formatting problems.

  * Use a for rather than a while loop in `dir_iterator_abort()` to
    improve the clarity.

  * Warn on failures of `opendir()`, `readdir()`, and `closedir()`
    that can't be explained as a simple race.

* In "for_each_reflog(): reimplement using iterators", make the vtable
  private.

These changes are also available from my GitHub fork [3] as branch
"ref-iterators".

Michael

[1] http://article.gmane.org/gmane.comp.version-control.git/296883
[2] http://thread.gmane.org/gmane.comp.version-control.git/296801
[3] https://github.com/mhagger/git

Michael Haggerty (13):
  refs: remove unnecessary "extern" keywords
  do_for_each_ref(): move docstring to the header file
  refs: use name "prefix" consistently
  delete_refs(): add a flags argument
  remote rm: handle symbolic refs correctly
  get_ref_cache(): only create an instance if there is a submodule
  entry_resolves_to_object(): rename function from
    ref_resolves_to_object()
  ref_resolves_to_object(): new function
  refs: introduce an iterator interface
  do_for_each_ref(): reimplement using reference iteration
  for_each_reflog(): don't abort for bad references
  dir_iterator: new API for iterating over a directory tree
  for_each_reflog(): reimplement using iterators

 Makefile             |   2 +
 builtin/fetch.c      |   2 +-
 builtin/remote.c     |   8 +-
 dir-iterator.c       | 202 +++++++++++++++++
 dir-iterator.h       |  87 +++++++
 iterator.h           |  81 +++++++
 refs.c               |  20 ++
 refs.h               | 139 +++++++-----
 refs/files-backend.c | 629 +++++++++++++++++++++++++++++++--------------------
 refs/iterator.c      | 384 +++++++++++++++++++++++++++++++
 refs/refs-internal.h | 226 +++++++++++++++++-
 11 files changed, 1458 insertions(+), 322 deletions(-)
 create mode 100644 dir-iterator.c
 create mode 100644 dir-iterator.h
 create mode 100644 iterator.h
 create mode 100644 refs/iterator.c

-- 
2.8.1


             reply	other threads:[~2016-06-18  4:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-18  4:15 Michael Haggerty [this message]
2016-06-18  4:15 ` [PATCH v3 01/13] refs: remove unnecessary "extern" keywords Michael Haggerty
2016-06-18  4:15 ` [PATCH v3 02/13] do_for_each_ref(): move docstring to the header file Michael Haggerty
2016-06-18  4:15 ` [PATCH v3 03/13] refs: use name "prefix" consistently Michael Haggerty
2016-06-18  4:15 ` [PATCH v3 04/13] delete_refs(): add a flags argument Michael Haggerty
2016-06-18  4:15 ` [PATCH v3 05/13] remote rm: handle symbolic refs correctly Michael Haggerty
2016-06-18  4:15 ` [PATCH v3 06/13] get_ref_cache(): only create an instance if there is a submodule Michael Haggerty
2016-06-18  4:15 ` [PATCH v3 07/13] entry_resolves_to_object(): rename function from ref_resolves_to_object() Michael Haggerty
2016-06-18  4:15 ` [PATCH v3 08/13] ref_resolves_to_object(): new function Michael Haggerty
2016-06-18  4:15 ` [PATCH v3 09/13] refs: introduce an iterator interface Michael Haggerty
2016-06-18  4:15 ` [PATCH v3 10/13] do_for_each_ref(): reimplement using reference iteration Michael Haggerty
2016-06-18  4:15 ` [PATCH v3 11/13] for_each_reflog(): don't abort for bad references Michael Haggerty
2016-06-18  4:15 ` [PATCH v3 12/13] dir_iterator: new API for iterating over a directory tree Michael Haggerty
2016-06-18  4:15 ` [PATCH v3 13/13] for_each_reflog(): reimplement using iterators Michael Haggerty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1466222921.git.mhagger@alum.mit.edu \
    --to=mhagger@alum.mit.edu \
    --cc=dturner@twopensource.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    --cc=ramsay@ramsayjones.plus.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).