From: Johannes Schindelin <johannes.schindelin@gmx.de>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
Thomas Gummerer <t.gummerer@gmail.com>,
Andrew Arnott <Andrew.Arnott@microsoft.com>
Subject: [PATCH 0/2] Fix remote_is_configured()
Date: Tue, 17 Jan 2017 22:18:58 +0100 (CET) [thread overview]
Message-ID: <cover.1484687919.git.johannes.schindelin@gmx.de> (raw)
A surprising behavior triggered the bug report in
https://github.com/git-for-windows/git/issues/888: the mere existence of
the config setting "remote.origin.prune" (in this instance, configured
via ~/.gitconfig so that it applies to all repositories) fooled `git
remote rename <source> <target>` into believing that the <target> remote
is already there.
This patch pair demonstrates the problem, and then fixes it (along with
potential similar problems, such as setting an HTTP proxy for remotes of
a given name via ~/.gitconfig).
Johannes Schindelin (2):
remote rename: demonstrate a bogus "remote exists" bug
Be more careful when determining whether a remote was configured
remote.c | 9 ++++++++-
remote.h | 2 +-
t/t5505-remote.sh | 9 +++++++++
3 files changed, 18 insertions(+), 2 deletions(-)
base-commit: d7dffce1cebde29a0c4b309a79e4345450bf352a
Published-As: https://github.com/dscho/git/releases/tag/rename-remote-v1
Fetch-It-Via: git fetch https://github.com/dscho/git rename-remote-v1
--
2.11.0.windows.3
next reply other threads:[~2017-01-17 21:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 21:18 Johannes Schindelin [this message]
2017-01-17 21:19 ` [PATCH 1/2] remote rename: demonstrate a bogus "remote exists" bug Johannes Schindelin
2017-01-17 21:19 ` [PATCH 2/2] Be more careful when determining whether a remote was configured Johannes Schindelin
2017-01-17 21:47 ` Jeff King
2017-01-17 22:19 ` Junio C Hamano
2017-01-18 12:38 ` Johannes Schindelin
2017-01-18 12:34 ` Johannes Schindelin
2017-01-18 12:54 ` Jeff King
2017-01-18 16:22 ` Johannes Schindelin
2017-01-19 18:27 ` Jeff King
2017-01-19 20:12 ` Junio C Hamano
2017-01-19 20:22 ` Jeff King
2017-01-19 21:19 ` Johannes Schindelin
2017-01-17 21:45 ` [PATCH 0/2] Fix remote_is_configured() Jeff King
2017-01-19 21:19 ` [PATCH v2 " Johannes Schindelin
2017-01-19 21:19 ` [PATCH v2 1/2] remote rename: demonstrate a bogus "remote exists" bug Johannes Schindelin
2017-01-19 21:20 ` [PATCH v2 2/2] Be more careful when determining whether a remote was configured Johannes Schindelin
2017-01-19 21:31 ` Jeff King
2017-01-19 21:44 ` Johannes Schindelin
2017-01-19 21:45 ` Junio C Hamano
2017-01-19 21:50 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1484687919.git.johannes.schindelin@gmx.de \
--to=johannes.schindelin@gmx.de \
--cc=Andrew.Arnott@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).