From: Johannes Schindelin <johannes.schindelin@gmx.de>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
Gergely Nagy <ngg@tresorit.com>, Aaron Teague <ateague@apple.com>,
jeremyhu@apple.com
Subject: [PATCH 0/1] difftool: fix a use-after-free bug
Date: Thu, 13 Apr 2017 21:21:53 +0200 (CEST) [thread overview]
Message-ID: <cover.1492111288.git.johannes.schindelin@gmx.de> (raw)
It has been reported previously that the base_dir recorded at the
beginning of run_dir_diff() may go stale due to the buffer to which it
points potentially being realloc()ed.
This bug has been fixed in Git for Windows 2.12.2(2) already. It took me
this long (!!!) to come up with a reliable test case... But now that I
have it, it can be easily verified.
Johannes Schindelin (1):
difftool: fix use-after-free
builtin/difftool.c | 7 +++++--
t/t7800-difftool.sh | 19 +++++++++++++++++++
2 files changed, 24 insertions(+), 2 deletions(-)
base-commit: cf11a67975b057a144618badf16dc4e3d25b9407
Published-As: https://github.com/dscho/git/releases/tag/fix-difftool-d-crash-v1
Fetch-It-Via: git fetch https://github.com/dscho/git fix-difftool-d-crash-v1
--
2.12.2.windows.2.1.g7df5db8d31e
next reply other threads:[~2017-04-13 19:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 19:21 Johannes Schindelin [this message]
2017-04-13 19:21 ` [PATCH 1/1] difftool: fix use-after-free Johannes Schindelin
2017-04-13 22:01 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1492111288.git.johannes.schindelin@gmx.de \
--to=johannes.schindelin@gmx.de \
--cc=ateague@apple.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeremyhu@apple.com \
--cc=ngg@tresorit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).