From: Jonathan Tan <jonathantanmy@google.com>
To: git@vger.kernel.org
Cc: Jonathan Tan <jonathantanmy@google.com>, git@jeffhostetler.com
Subject: [WIP 0/2] Modifying pack-objects to support --blob-size-limit
Date: Thu, 1 Jun 2017 17:14:53 -0700 [thread overview]
Message-ID: <cover.1496361873.git.jonathantanmy@google.com> (raw)
I took a look at modifying builtin/pack-objects.c to support excluding
oversized blobs and reporting the exclusions that it has performed.
Here's a work in progress - it might be of aid to others who are working
on a similar feature and/or are modifying pack-objects for something
else.
The way I used to obtain a blob's size seems inefficient and redundant
with check_object() - if you have a suggestion to improve this, I'm
interested.
This is similar to [1] except that this reports blobs and their sizes
(after the packfile is printed), and is slightly more comprehensive in
that the read_object_list_from_stdin() codepath is also covered in
addition to the get_object_list() codepath. (Although, to be clear,
upload-pack always passes "--revs" and thus only needs the
get_object_list() codepath).
[1] https://public-inbox.org/git/1488994685-37403-3-git-send-email-jeffhost@microsoft.com/
Jonathan Tan (2):
pack-objects: rename want_.* to ignore_.*
pack-objects: support --blob-size-limit
Documentation/git-pack-objects.txt | 19 ++++-
builtin/pack-objects.c | 163 ++++++++++++++++++++++++++++++-------
t/t5300-pack-object.sh | 71 ++++++++++++++++
3 files changed, 223 insertions(+), 30 deletions(-)
--
2.13.0.506.g27d5fe0cd-goog
next reply other threads:[~2017-06-02 0:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 0:14 Jonathan Tan [this message]
2017-06-02 0:14 ` [WIP 1/2] pack-objects: rename want_.* to ignore_.* Jonathan Tan
2017-06-02 3:45 ` Junio C Hamano
2017-06-02 0:14 ` [WIP 2/2] pack-objects: support --blob-size-limit Jonathan Tan
2017-06-02 4:48 ` Junio C Hamano
2017-06-02 19:38 ` [WIP v2 0/2] Modifying pack objects to support --blob-max-bytes Jonathan Tan
2017-06-02 22:16 ` Jeff King
2017-06-05 17:35 ` Jonathan Tan
2017-06-07 9:46 ` Jeff King
2017-06-02 19:38 ` [WIP v2 1/2] pack-objects: rename want_.* to ignore_.* Jonathan Tan
2017-06-02 19:38 ` [WIP v2 2/2] pack-objects: support --blob-max-bytes Jonathan Tan
2017-06-02 22:26 ` Jeff King
2017-06-02 23:25 ` Jonathan Nieder
2017-06-07 9:44 ` Jeff King
2017-06-03 23:48 ` Junio C Hamano
2017-06-15 20:28 ` Jeff Hostetler
2017-06-15 21:03 ` Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1496361873.git.jonathantanmy@google.com \
--to=jonathantanmy@google.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).