From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Stefan Beller" <sbeller@google.com>, "Jeff King" <peff@peff.net>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"David Turner" <novalis@novalis.org>,
"Brandon Williams" <bmwill@google.com>,
"Johannes Sixt" <j6t@kdbg.org>, "Øyvind Holm" <sunny@sunbase.org>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
git@vger.kernel.org, "Michael Haggerty" <mhagger@alum.mit.edu>
Subject: [PATCH v2 0/2] Fix a refname trimming problem in `log --bisect`
Date: Sun, 18 Jun 2017 15:39:40 +0200 [thread overview]
Message-ID: <cover.1497792827.git.mhagger@alum.mit.edu> (raw)
This is v2 of these patches. Thanks to Peff and Junio for their
feedback about v1 [1].
Changes since v1:
* Added a test and tweaked the commit message of the first patch.
As before, the second patch is optional. If it is omitted, it might
flush out any other bugs like this one in client code. If it is
included, regressions are less likely, but we won't learn about other
misuses of the API. I have no strong opinion either way.
Michael
[1] http://public-inbox.org/git/cover.1497430232.git.mhagger@alum.mit.edu/
Michael Haggerty (2):
for_each_bisect_ref(): don't trim refnames
prefix_ref_iterator_advance(): relax the check of trim length
refs.c | 12 ++++++++++++
refs.h | 5 ++++-
refs/iterator.c | 8 ++++----
revision.c | 2 +-
t/t6002-rev-list-bisect.sh | 14 ++++++++++++++
5 files changed, 35 insertions(+), 6 deletions(-)
--
2.11.0
next reply other threads:[~2017-06-18 13:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-18 13:39 Michael Haggerty [this message]
2017-06-18 13:39 ` [PATCH v2 1/2] for_each_bisect_ref(): don't trim refnames Michael Haggerty
2017-06-18 13:39 ` [PATCH v2 2/2] prefix_ref_iterator_advance(): relax the check of trim length Michael Haggerty
2017-06-19 9:16 ` [PATCH v2 0/2] Fix a refname trimming problem in `log --bisect` Jeff King
2017-06-19 15:51 ` Junio C Hamano
2017-06-19 16:05 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1497792827.git.mhagger@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=avarab@gmail.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=novalis@novalis.org \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=sbeller@google.com \
--cc=sunny@sunbase.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).