From: Wink Saville <wink@saville.com>
To: git@vger.kernel.org
Cc: Wink Saville <wink@saville.com>,
gitster@pobox.com, jeffhost@microsoft.com,
ramsay@ramsayjones.plus.com
Subject: [RFC PATCH 0/1] json-writer: add cast to uintmax_t
Date: Sat, 24 Mar 2018 11:38:31 -0700 [thread overview]
Message-ID: <cover.1521916335.git.wink@saville.com> (raw)
In-Reply-To: <cover.1521868951.git.wink@saville.com>
Building the pu branch at commit 8b49f5c076c using Travis-Ci all linux
builds worked but the two OSX builds failed with:
CC ident.o
CC json-writer.o
json-writer.c:123:38: error: format specifies type 'uintmax_t' (aka 'unsigned long') but the argument has type 'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat]
strbuf_addf(&jw->json, ":%"PRIuMAX, value);
json-writer.c:228:37: error: format specifies type 'uintmax_t' (aka 'unsigned long') but the argument has type 'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat]
strbuf_addf(&jw->json, "%"PRIuMAX, value);
Corrected in Patch 1/1 by casting value to uintmax_t.
Wink Saville (1):
json-writer: add cast to uintmax_t
json-writer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
2.16.2
next prev parent reply other threads:[~2018-03-24 18:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-24 5:37 [RFC PATCH 0/1] json-writer: incorrect format specifier Wink Saville
2018-03-24 5:37 ` [RFC PATCH 1/1] " Wink Saville
2018-03-24 11:11 ` Jeff Hostetler
2018-03-24 15:14 ` Ramsay Jones
2018-03-24 16:07 ` Ramsay Jones
2018-03-26 17:04 ` Junio C Hamano
2018-03-26 17:39 ` Jeff Hostetler
2018-03-27 3:26 ` Ramsay Jones
2018-03-27 10:24 ` Jeff Hostetler
2018-03-24 18:38 ` Wink Saville [this message]
2018-03-24 18:38 ` [RFC PATCH v2 1/1] json-writer: add cast to uintmax_t Wink Saville
2018-03-26 17:36 ` Jeff Hostetler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1521916335.git.wink@saville.com \
--to=wink@saville.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).