From: "Martin Ågren" <martin.agren@gmail.com>
To: git@vger.kernel.org
Cc: David Turner <novalis@novalis.org>,
Duy Nguyen <pclouds@gmail.com>, Jeff King <peff@peff.net>,
Stefan Beller <sbeller@google.com>
Subject: [PATCH v2 0/5] getting rid of most "static struct lock_file"s
Date: Wed, 9 May 2018 22:55:34 +0200 [thread overview]
Message-ID: <cover.1525898125.git.martin.agren@gmail.com> (raw)
In-Reply-To: <20180508182548.GD7210@sigill.intra.peff.net>
This is take two of my attempt at making almost all `struct lock_file`s
non-static. All patches have been equipped with more detailed commit
messages. The only diff that has changed is patch 3/5, where I now take
a small step towards gentle error-handling, rather than going in the
opposite direction.
Thanks all for the valuable feedback on v1. I could have saved everyone
some trouble by writing better commit messages from the start, and
probably also by using `--thread` when formatting the patches...
Martin
Martin Ågren (5):
t/helper/test-write-cache: clean up lock-handling
refs.c: do not die if locking fails in `write_pseudoref()`
refs.c: do not die if locking fails in `delete_pseudoref()`
lock_file: make function-local locks non-static
lock_file: move static locks into functions
t/helper/test-scrap-cache-tree.c | 4 ++--
t/helper/test-write-cache.c | 14 +++++---------
apply.c | 2 +-
builtin/add.c | 3 +--
builtin/describe.c | 2 +-
builtin/difftool.c | 2 +-
builtin/gc.c | 2 +-
builtin/merge.c | 4 ++--
builtin/mv.c | 2 +-
builtin/read-tree.c | 3 +--
builtin/receive-pack.c | 2 +-
builtin/rm.c | 3 +--
bundle.c | 2 +-
fast-import.c | 2 +-
refs.c | 16 +++++++++-------
refs/files-backend.c | 2 +-
rerere.c | 3 +--
shallow.c | 2 +-
18 files changed, 32 insertions(+), 38 deletions(-)
--
2.17.0.411.g9fd64c8e46
next prev parent reply other threads:[~2018-05-09 20:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-06 14:10 [PATCH 0/5] getting rid of most "static struct lock_file"s Martin Ågren
2018-05-08 18:25 ` Jeff King
2018-05-09 20:55 ` Martin Ågren [this message]
2018-05-09 20:55 ` [PATCH v2 1/5] t/helper/test-write-cache: clean up lock-handling Martin Ågren
2018-05-09 20:55 ` [PATCH v2 2/5] refs.c: do not die if locking fails in `write_pseudoref()` Martin Ågren
2018-05-09 20:55 ` [PATCH v2 3/5] refs.c: do not die if locking fails in `delete_pseudoref()` Martin Ågren
2018-05-09 20:55 ` [PATCH v2 4/5] lock_file: make function-local locks non-static Martin Ågren
2018-05-09 20:55 ` [PATCH v2 5/5] lock_file: move static locks into functions Martin Ågren
2018-05-10 5:21 ` [PATCH v2 0/5] getting rid of most "static struct lock_file"s Jeff King
2018-05-10 6:01 ` Junio C Hamano
2018-05-10 7:47 ` Martin Ågren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1525898125.git.martin.agren@gmail.com \
--to=martin.agren@gmail.com \
--cc=git@vger.kernel.org \
--cc=novalis@novalis.org \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).