From: Jonathan Tan <jonathantanmy@google.com>
To: git@vger.kernel.org
Cc: Jonathan Tan <jonathantanmy@google.com>, gitster@pobox.com
Subject: [PATCH v2 0/2] Check presence of targets when fetching to partial clone
Date: Fri, 21 Sep 2018 11:22:36 -0700 [thread overview]
Message-ID: <cover.1537553700.git.jonathantanmy@google.com> (raw)
In-Reply-To: <20180920184843.20898-1-jonathantanmy@google.com>
New in v2:
- added patch to clarify in documentation what check_connected() does
- renamed quickfetch() to check_exist_and_connected() to better reflect
what it does
- also updated its documentation; I avoided usage of "wanted objects"
and used "fetch targets" instead to clarify that I'm only talking
about the direct targets, not all objects referenced by those targets
- in check_exist_and_connected() (previously quickfetch()), check
existence directly regardless of whether the repository is a partial
clone or not
This should resolve most of Junio's comments in [1], except that I chose
not to modify or rename check_connected(). In this current world, it is
true that we usually require existence of ref targets, but that might
not be so in the future (having said that, I don't know of any schedules
for this future). Also, check_connected() is used in a few places, so
such a change would cause some churn in the codebase. So I left this
function alone.
[1] https://public-inbox.org/git/xmqqy3bvycie.fsf@gitster-ct.c.googlers.com/
Jonathan Tan (2):
connected: document connectivity in partial clones
fetch: in partial clone, check presence of targets
builtin/fetch.c | 15 +++++++++++++--
connected.h | 6 +++---
t/t5616-partial-clone.sh | 17 +++++++++++++++++
3 files changed, 33 insertions(+), 5 deletions(-)
--
2.19.0.444.g18242da7ef-goog
next prev parent reply other threads:[~2018-09-21 18:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 18:48 [PATCH] fetch: in partial clone, check presence of targets Jonathan Tan
2018-09-20 20:50 ` Junio C Hamano
2018-09-20 22:10 ` Jonathan Tan
2018-09-20 23:28 ` Junio C Hamano
2018-09-21 18:22 ` Jonathan Tan [this message]
2018-09-21 18:22 ` [PATCH v2 1/2] connected: document connectivity in partial clones Jonathan Tan
2018-09-21 20:19 ` Junio C Hamano
2018-09-21 18:22 ` [PATCH v2 2/2] fetch: in partial clone, check presence of targets Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1537553700.git.jonathantanmy@google.com \
--to=jonathantanmy@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).