From: Jonathan Chang <ttjtftx@gmail.com>
To: Git Mailing List <git@vger.kernel.org>
Cc: "Jonathan Chang" <ttjtftx@gmail.com>,
"Christian Couder" <christian.couder@gmail.com>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Thomas Gummerer" <t.gummerer@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: [GSoC][PATCH v4 0/5] Avoid using pipes
Date: Sat, 30 Mar 2019 22:27:53 +0800 [thread overview]
Message-ID: <cover.1553954776.git.ttjtftx@gmail.com> (raw)
I added 2 additional patches that modernize style, based on discussion
in [1].
Also added description in commit message as suggested in [2].
[v1]: https://public-inbox.org/git/20190309154555.33407-1-ttjtftx@gmail.com/
[v2]: https://public-inbox.org/git/20190310080739.63984-1-ttjtftx@gmail.com/
[v3]: https://public-inbox.org/git/cover.1552835153.git.ttjtftx@gmail.com/
[1]: https://public-inbox.org/git/87imwha1o3.fsf@evledraar.gmail.com/
[2]: https://public-inbox.org/git/20190317200609.GA1216@hank.intra.tgummerer.com/
Jonathan Chang (5):
t0000: fix indentation
t0000: avoid using pipes
t0000: use test_line_count instead of wc -l
t0000: use test_cmp instead of "test" builtin
t0000: make use of the test_must_be_empty function
t/t0000-basic.sh | 41 +++++++++++++++++++++--------------------
1 file changed, 21 insertions(+), 20 deletions(-)
Range-diff against v3:
1: 768bf373d0 = 1: 86146182b7 t0000: fix indentation
2: 8ee5e073a2 ! 2: 1ca1168f91 t0000: avoid using pipes
@@ -6,6 +6,10 @@
using it. By writing out the output of the git command to a file, we can
test the exit codes of both the commands.
+ This commit doesn't make any additional simplifications, such as using
+ the test_line_count function for counting the lines in the output. These
+ simplifications will be made in subsequent commits.
+
Signed-off-by: Jonathan Chang <ttjtftx@gmail.com>
diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
3: 68590a40d7 = 3: 28986ed000 t0000: use test_line_count instead of wc -l
-: ---------- > 4: 731463ed98 t0000: use test_cmp instead of "test" builtin
-: ---------- > 5: 53f58a4f89 t0000: make use of the test_must_be_empty function
--
2.21.0
next reply other threads:[~2019-03-30 14:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-30 14:27 Jonathan Chang [this message]
2019-03-30 14:27 ` [GSoC][PATCH v4 1/5] t0000: fix indentation Jonathan Chang
2019-03-30 14:27 ` [GSoC][PATCH v4 2/5] t0000: avoid using pipes Jonathan Chang
2019-03-30 14:27 ` [GSoC][PATCH v4 3/5] t0000: use test_line_count instead of wc -l Jonathan Chang
2019-03-30 14:27 ` [GSoC][PATCH v4 4/5] t0000: use test_cmp instead of "test" builtin Jonathan Chang
2019-03-30 19:38 ` Thomas Gummerer
2019-03-31 5:17 ` jonathan chang
2019-03-31 18:57 ` Thomas Gummerer
2019-03-30 14:27 ` [GSoC][PATCH v4 5/5] t0000: make use of the test_must_be_empty function Jonathan Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1553954776.git.ttjtftx@gmail.com \
--to=ttjtftx@gmail.com \
--cc=avarab@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).