From: Taylor Blau <me@ttaylorr.com>
To: git@vger.kernel.org
Cc: vdye@github.com, gitster@pobox.com
Subject: [PATCH 0/3] repack: handle --keep-pack, --max-pack-size for geometric repacks
Date: Fri, 20 May 2022 15:01:41 -0400 [thread overview]
Message-ID: <cover.1653073280.git.me@ttaylorr.com> (raw)
This series fixes two issues that Victoria and I noticed while working on an
unrelated issue yesterday.
- The first patch comes from Victoria's earlier submission[1], and addresses
an issue where packs specified as kept via the `--keep-pack` option could
potentially be removed (without rewriting their objects) during a
`--geometric` repack.
The first patch is Victoria's alone, with some minor fixups applied from my
review in [2]. It's included in this series since it's related, and avoids
any conflicts when merging.
- The latter two patches are mine, and address an issue where specifying a
`--max-pack-size` value during a `--geometric` repack could result in object
loss because of a false positive in our "did we write a pack with this
name?" check (which can occur when the list of packs we wrote isn't sorted).
The first of these two patches demonstrates the issue (done in a separate
patch, since the scenario is quite involved), and the second patch fixes the
bug.
Thanks in advance for your review.
[1]: https://lore.kernel.org/git/pull.1235.git.1653064572170.gitgitgadget@gmail.com/
[2]: https://lore.kernel.org/git/YofJLv8+x5J7yPmf@nand.local/
Taylor Blau (2):
t7703: demonstrate object corruption with pack.packSizeLimit
builtin/repack.c: ensure that `names` is sorted
Victoria Dye (1):
repack: respect --keep-pack with geometric repack
builtin/repack.c | 49 ++++++++++++++++++------
t/t7703-repack-geometric.sh | 75 +++++++++++++++++++++++++++++++++++++
2 files changed, 112 insertions(+), 12 deletions(-)
--
2.36.1.94.gb0d54bedca
next reply other threads:[~2022-05-20 19:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 19:01 Taylor Blau [this message]
2022-05-20 19:01 ` [PATCH 1/3] repack: respect --keep-pack with geometric repack Taylor Blau
2022-05-20 19:01 ` [PATCH 2/3] t7703: demonstrate object corruption with pack.packSizeLimit Taylor Blau
2022-05-20 19:42 ` Victoria Dye
2022-05-20 23:22 ` Taylor Blau
2022-05-20 20:54 ` Junio C Hamano
2022-05-20 19:01 ` [PATCH 3/3] builtin/repack.c: ensure that `names` is sorted Taylor Blau
2022-05-20 19:46 ` [PATCH 0/3] repack: handle --keep-pack, --max-pack-size for geometric repacks Victoria Dye
2022-05-20 20:05 ` Derrick Stolee
2022-05-20 20:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1653073280.git.me@ttaylorr.com \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).