From: Taylor Blau <me@ttaylorr.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
Derrick Stolee <derrickstolee@github.com>
Subject: [PATCH 0/6] fsck: squelch progress output with `--no-progress`
Date: Fri, 7 Jul 2023 20:31:28 -0400 [thread overview]
Message-ID: <cover.1688776280.git.me@ttaylorr.com> (raw)
This short series addresses a pair of issues where the `commit-graph
verify` and `multi-pack-index verify` steps of `git fsck` produce output
regardless of whether or not `fsck` was invoked with the
`--no-progress` option or not.
The first two patches address the commit-graph and MIDX issues
respectively. The final four patches further clean up the output of
`git commit-graph verify --progress` when verifying multi-layer graphs
to produce a single progress meter instead of one per graph layer.
Before, the output of `git commit-graph verify` on a repository with a
commit-graph chain with two layers looked like:
$ git.compile commit-graph verify
Verifying commits in commit graph: 100% (4356/4356), done.
Verifying commits in commit graph: 100% (131912/131912), done.
After this patch series, the output instead looks as follows:
$ git.compile commit-graph verify
Verifying commits in commit graph: 100% (136268/136268), done.
Thanks in advance for your review.
Taylor Blau (6):
fsck: suppress commit-graph output with `--no-progress`
fsck: suppress MIDX output with `--no-progress`
commit-graph.c: extract `verify_one_commit_graph()`
commit-graph.c: iteratively verify commit-graph chains
commit-graph.c: pass progress to `verify_one_commit_graph()`
commit-graph.c: avoid duplicated progress output during `verify`
builtin/fsck.c | 8 ++++++
commit-graph.c | 53 +++++++++++++++++++++++------------
t/t5318-commit-graph.sh | 10 +++++++
t/t5319-multi-pack-index.sh | 12 ++++++++
t/t5324-split-commit-graph.sh | 3 +-
5 files changed, 67 insertions(+), 19 deletions(-)
--
2.41.0.242.g6eec849fa5a
next reply other threads:[~2023-07-08 0:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-08 0:31 Taylor Blau [this message]
2023-07-08 0:31 ` [PATCH 1/6] fsck: suppress commit-graph output with `--no-progress` Taylor Blau
2023-07-08 0:31 ` [PATCH 2/6] fsck: suppress MIDX " Taylor Blau
2023-07-08 0:31 ` [PATCH 3/6] commit-graph.c: extract `verify_one_commit_graph()` Taylor Blau
2023-07-08 0:31 ` [PATCH 4/6] commit-graph.c: iteratively verify commit-graph chains Taylor Blau
2023-07-08 0:31 ` [PATCH 5/6] commit-graph.c: pass progress to `verify_one_commit_graph()` Taylor Blau
2023-07-08 0:31 ` [PATCH 6/6] commit-graph.c: avoid duplicated progress output during `verify` Taylor Blau
2023-07-10 15:55 ` [PATCH 0/6] fsck: squelch progress output with `--no-progress` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1688776280.git.me@ttaylorr.com \
--to=me@ttaylorr.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).