From: Taylor Blau <me@ttaylorr.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
Derrick Stolee <derrickstolee@github.com>,
Jeff King <peff@peff.net>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Victoria Dye <vdye@github.com>
Subject: [PATCH 0/2] repack: make `collect_pack_filenames()` consistent
Date: Mon, 10 Jul 2023 15:37:12 -0400 [thread overview]
Message-ID: <cover.1689017830.git.me@ttaylorr.com> (raw)
This series combines a patch that Stolee wrote[1] as an RFC, along with
one that I added as a follow-up on top[2].
The details are spelled out in the commit messages, but the gist is that
the first patch restores behavior from prior to 73320e49ad
(builtin/repack.c: only collect fully-formed packs, 2023-06-07).
The second patch does not change any behavior, but reimplements
`collect_pack_filenames()` in terms of `get_all_packs()`, to make `git
repack`'s notion of which packs exist in a usable state in the
repository is consistent with `add_packed_git()`,
`install_packed_git()`, etc.
[1]: https://lore.kernel.org/git/pull.1546.git.1687287782439.gitgitgadget@gmail.com/
[2]: https://lore.kernel.org/git/ZJ1N2I6sDfxhrJo8@nand.local/
Derrick Stolee (1):
builtin/repack.c: only repack `.pack`s that exist
Taylor Blau (1):
builtin/repack.c: avoid dir traversal in `collect_pack_filenames()`
builtin/repack.c | 38 +++++++++++++++-----------------------
t/t7700-repack.sh | 47 ++++++++++++++++++++++++++++++++++++++++++-----
2 files changed, 57 insertions(+), 28 deletions(-)
--
2.41.0.320.gb3d0d9308ef
next reply other threads:[~2023-07-10 19:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 19:37 Taylor Blau [this message]
2023-07-10 19:37 ` [PATCH 1/2] builtin/repack.c: only repack `.pack`s that exist Taylor Blau
2023-07-10 20:09 ` Junio C Hamano
2023-07-11 17:28 ` Taylor Blau
2023-07-10 19:37 ` [PATCH 2/2] builtin/repack.c: avoid dir traversal in `collect_pack_filenames()` Taylor Blau
2023-07-10 21:35 ` Junio C Hamano
2023-07-11 17:29 ` Taylor Blau
2023-07-11 17:32 ` [PATCH v2 0/2] repack: make `collect_pack_filenames()` consistent Taylor Blau
2023-07-11 17:32 ` [PATCH v2 1/2] builtin/repack.c: only repack `.pack`s that exist Taylor Blau
2023-07-11 17:32 ` [PATCH v2 2/2] builtin/repack.c: avoid dir traversal in `collect_pack_filenames()` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1689017830.git.me@ttaylorr.com \
--to=me@ttaylorr.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).