From: Taylor Blau <me@ttaylorr.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>
Subject: [PATCH 0/2] repack: prevent geometry struct leak
Date: Wed, 9 Aug 2023 16:32:36 -0400 [thread overview]
Message-ID: <cover.1691613149.git.me@ttaylorr.com> (raw)
In-Reply-To: <20230808211759.GA322409@coredump.intra.peff.net>
This short series combines a patch from Peff and a patch from me to
prevent leaking the 'struct pack_geometry *' pointer from the repack
code.
The first patch free()s the heap-allocated struct, and the second
patch moves the variable to be allocated on the stack.
Jeff King (1):
repack: free geometry struct
Taylor Blau (1):
repack: move `pack_geometry` struct to the stack
builtin/repack.c | 66 +++++++++++++++++++++++-------------------------
1 file changed, 32 insertions(+), 34 deletions(-)
--
2.42.0.rc0.27.g2e2a760381
next prev parent reply other threads:[~2023-08-09 20:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 18:50 [PATCH] repack: free geometry struct Jeff King
2023-08-08 19:59 ` Taylor Blau
2023-08-08 21:17 ` Jeff King
2023-08-09 20:32 ` Taylor Blau [this message]
2023-08-09 20:32 ` [PATCH 1/2] " Taylor Blau
2023-08-09 20:32 ` [PATCH 2/2] repack: move `pack_geometry` struct to the stack Taylor Blau
2023-08-10 0:19 ` [PATCH 0/2] repack: prevent geometry struct leak Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1691613149.git.me@ttaylorr.com \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).