From: Patrick Steinhardt <ps@pks.im>
To: git@vger.kernel.org
Cc: "Stan Hu" <stanhu@gmail.com>,
"SZEDER Gábor" <szeder.dev@gmail.com>,
"Jeff King" <peff@peff.net>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Junio C Hamano" <gitster@pobox.com>
Subject: [PATCH v2 0/5] completion: silence pseudo-ref existence check
Date: Mon, 15 Jan 2024 11:35:53 +0100 [thread overview]
Message-ID: <cover.1705314554.git.ps@pks.im> (raw)
In-Reply-To: <cover.1704969119.git.ps@pks.im>
[-- Attachment #1: Type: text/plain, Size: 1428 bytes --]
Hi,
this is the second version of my patch series that refactors the Bash
completion scripts to work better with reftables. Changes compared to
v1:
- I've incorporated SZEDER's feedback that he has sent in reply to the
original patch series that is already in `master`. Most importantly,
we now discover the repo path in `__git_pseudoref_exists ()` itself.
- I've included some refactorings to stop leaking local variables in
`__git_pseudoref_exists ()`.
- I've added tests for `__git_pseudoref_exists ()` directly, which was
also suggested by SZEDER.
- I've marked t9902 with `test_untraceable` now to unbreak macOS CI.
- I've refactored the completion test to use `git show-ref --exists`
to fix an issue with unborn pseudorefs that I didn't notice
previously.
I didn't include a range-diff because quite a lof of things have moved
around.
Patrick
Patrick Steinhardt (5):
completion: discover repo path in `__git_pseudoref_exists ()`
t9902: verify that completion does not print anything
completion: improve existence check for pseudo-refs
completion: silence pseudoref existence check
completion: treat dangling symrefs as existing pseudorefs
contrib/completion/git-completion.bash | 11 +++---
t/t9902-completion.sh | 47 ++++++++++++++++++++++++--
2 files changed, 50 insertions(+), 8 deletions(-)
--
2.43.GIT
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-01-15 10:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 10:41 [PATCH 0/2] completion: silence pseudo-ref existence check Patrick Steinhardt
2024-01-11 10:41 ` [PATCH 1/2] t9902: verify that completion does not print anything Patrick Steinhardt
2024-01-11 20:29 ` Junio C Hamano
2024-01-12 10:08 ` Johannes Schindelin
2024-01-12 10:50 ` Patrick Steinhardt
2024-01-12 13:12 ` Johannes Schindelin
2024-01-12 15:16 ` Jeff King
2024-01-12 18:17 ` Junio C Hamano
2024-01-15 9:02 ` Patrick Steinhardt
2024-01-11 10:41 ` [PATCH 2/2] completion: silence pseudoref existence check Patrick Steinhardt
2024-01-11 21:03 ` Junio C Hamano
2024-01-13 19:17 ` SZEDER Gábor
2024-01-15 10:35 ` Patrick Steinhardt [this message]
2024-01-15 10:35 ` [PATCH v2 1/5] completion: discover repo path in `__git_pseudoref_exists ()` Patrick Steinhardt
2024-01-15 10:36 ` [PATCH v2 2/5] t9902: verify that completion does not print anything Patrick Steinhardt
2024-01-15 10:36 ` [PATCH v2 3/5] completion: improve existence check for pseudo-refs Patrick Steinhardt
2024-01-15 10:36 ` [PATCH v2 4/5] completion: silence pseudoref existence check Patrick Steinhardt
2024-01-15 10:36 ` [PATCH v2 5/5] completion: treat dangling symrefs as existing pseudorefs Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1705314554.git.ps@pks.im \
--to=ps@pks.im \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=stanhu@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).