From: Taylor Blau <me@ttaylorr.com>
To: git@vger.kernel.org
Cc: Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>,
Patrick Steinhardt <pk@pks.im>
Subject: [PATCH v2 0/2] pack-objects: enable multi-pack reuse via feature.experimental
Date: Mon, 5 Feb 2024 17:50:16 -0500 [thread overview]
Message-ID: <cover.1707173415.git.me@ttaylorr.com> (raw)
In-Reply-To: <cover.1705431816.git.me@ttaylorr.com>
Here is a small reroll of my series to teache pack-objects to perform
multi-pack reuse by way of the feature.experimental configuration.
Similar to last time, the hope is that this will expose this new feature
to more users who might not otherwise be aware of lesser-known
configuration options for pack-objects's internals.
The only changes since last time are as follows:
- Rebased forward onto 2a540e432f (The thirteenth batch, 2024-02-02).
- Re-introduced a missing `--delta-base-offset` argument into the new
helper function added and used by t5332.
Thanks in advance for your review!
Taylor Blau (2):
t5332-multi-pack-reuse.sh: extract pack-objects helper functions
pack-objects: enable multi-pack reuse via `feature.experimental`
Documentation/config/feature.txt | 3 ++
builtin/pack-objects.c | 2 +
repo-settings.c | 1 +
repository.h | 1 +
t/t5332-multi-pack-reuse.sh | 85 +++++++++++++++++---------------
5 files changed, 51 insertions(+), 41 deletions(-)
Range-diff against v1:
1: 94dd41e1af ! 1: db3d67bfa3 t5332-multi-pack-reuse.sh: extract pack-objects helper functions
@@ t/t5332-multi-pack-reuse.sh: pack_position () {
+test_pack_objects_reused_all () {
+ : >trace2.txt &&
+ GIT_TRACE2_EVENT="$PWD/trace2.txt" \
-+ git pack-objects --stdout --revs --all >/dev/null &&
++ git pack-objects --stdout --revs --all --delta-base-offset \
++ >/dev/null &&
+
+ test_pack_reused "$1" <trace2.txt &&
+ test_packs_reused "$2" <trace2.txt
2: a2d0af562a = 2: 683ffd154e pack-objects: enable multi-pack reuse via `feature.experimental`
base-commit: 2a540e432fe5dff3cfa9d3bf7ca56db2ad12ebb9
--
2.43.0.524.g683ffd154e
next prev parent reply other threads:[~2024-02-05 22:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 19:03 [PATCH 0/2] pack-objects: enable multi-pack reuse via feature.experimental Taylor Blau
2024-01-16 19:03 ` [PATCH 1/2] t5332-multi-pack-reuse.sh: extract pack-objects helper functions Taylor Blau
2024-01-17 7:32 ` Patrick Steinhardt
2024-02-05 22:44 ` Taylor Blau
2024-01-16 19:03 ` [PATCH 2/2] pack-objects: enable multi-pack reuse via `feature.experimental` Taylor Blau
2024-01-17 7:32 ` Patrick Steinhardt
2024-02-05 22:48 ` Taylor Blau
2024-02-05 22:50 ` Taylor Blau [this message]
2024-02-05 22:50 ` [PATCH v2 1/2] t5332-multi-pack-reuse.sh: extract pack-objects helper functions Taylor Blau
2024-02-06 7:25 ` Patrick Steinhardt
2024-02-05 22:50 ` [PATCH v2 2/2] pack-objects: enable multi-pack reuse via `feature.experimental` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1707173415.git.me@ttaylorr.com \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=pk@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).