git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josh Steadmon <steadmon@google.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com
Subject: [PATCH v2 0/3] Add additional trace2 regions for fetch and push
Date: Thu, 22 Aug 2024 14:57:44 -0700	[thread overview]
Message-ID: <cover.1724363615.git.steadmon@google.com> (raw)
In-Reply-To: <cover.1723747832.git.steadmon@google.com>

Last year at $DAYJOB we were having issues with slow
fetches/pulls/pushes. We added some additional trace2 regions which
helped us narrow down the issue to some server-side negotiation
problems. We've been carrying these patches downstream ever since, but
they might be useful to others as well.

Changes in V2:

* Added a new patch to implement trace2_printf() for event targets.

* Move some fetch trace regions deeper in the call stack to simplify
  control flow.

* Move some push trace regions deeper in the call stack to target the
  actual slow functions, and to not tie tracing to whether or not
  sideband communication is used.


Calvin Wan (1):
  send-pack: add new tracing regions for push

Josh Steadmon (2):
  trace2: implement trace2_printf() for event target
  fetch: add top-level trace2 regions

 Documentation/technical/api-trace2.txt | 17 +++++++++++++++--
 builtin/fetch.c                        | 16 +++++++++++++++-
 bundle-uri.c                           |  4 ++++
 send-pack.c                            | 16 +++++++++++++---
 trace2/tr2_tgt_event.c                 | 22 ++++++++++++++++++++--
 5 files changed, 67 insertions(+), 8 deletions(-)

base-commit: 25673b1c476756ec0587fb0596ab3c22b96dc52a
-- 
2.46.0.295.g3b9ea8a38a-goog


  parent reply	other threads:[~2024-08-22 21:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-15 18:51 [PATCH 0/2] Add additional trace2 regions for fetch and push Josh Steadmon
2024-08-15 18:51 ` [PATCH 1/2] fetch: add top-level trace2 regions Josh Steadmon
2024-08-15 19:47   ` Junio C Hamano
2024-08-19 18:26     ` Josh Steadmon
2024-08-15 18:51 ` [PATCH 2/2] send-pack: add new tracing regions for push Josh Steadmon
2024-08-15 20:06   ` Junio C Hamano
2024-08-22 20:20     ` Josh Steadmon
2024-08-22 20:30       ` Junio C Hamano
2024-08-22 21:57 ` Josh Steadmon [this message]
2024-08-22 21:57   ` [PATCH v2 1/3] trace2: implement trace2_printf() for event target Josh Steadmon
2024-08-22 21:57   ` [PATCH v2 2/3] fetch: add top-level trace2 regions Josh Steadmon
2024-08-22 21:57   ` [PATCH v2 3/3] send-pack: add new tracing regions for push Josh Steadmon
2024-08-22 22:10   ` [PATCH v2 0/3] Add additional trace2 regions for fetch and push Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1724363615.git.steadmon@google.com \
    --to=steadmon@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).