From: Taylor Blau <me@ttaylorr.com>
To: git@vger.kernel.org
Cc: Elijah Newren <newren@gmail.com>, Jeff King <peff@peff.net>,
Junio C Hamano <gitster@pobox.com>,
"brian m. carlson" <sandals@crustytoothpaste.net>
Subject: [PATCH v2 0/2] t/helper/test-tool: implement 'sha1-unsafe' helper
Date: Tue, 5 Nov 2024 14:05:10 -0500 [thread overview]
Message-ID: <cover.1730833506.git.me@ttaylorr.com> (raw)
This series implements a new 'sha1-unsafe' test helper, similar to
't/helper/test-tool sha1'.
I have found such a helper to be really handy when debugging the new
SHA1_UNSAFE build knobs, e.g., to easily compare the performance of the
safe versus unsafe routines, different unsafe variants, etc.
The first patch prepares us by setting up the existing cmd_hash_impl()
function to be able to conditionally use the unsafe variant. The final
patch introduces a new 'sha1-unsafe' test helper which calls the new
variant.
Thanks in advance for your review!
Taylor Blau (2):
t/helper/test-sha1: prepare for an unsafe mode
t/helper/test-tool: implement sha1-unsafe helper
t/helper/test-hash.c | 17 +++++++++++++----
t/helper/test-sha1.c | 7 ++++++-
t/helper/test-sha1.sh | 38 ++++++++++++++++++++++----------------
t/helper/test-sha256.c | 2 +-
t/helper/test-tool.c | 1 +
t/helper/test-tool.h | 3 ++-
6 files changed, 45 insertions(+), 23 deletions(-)
Range-diff against v1:
1: 3b31db4d2df = 1: 0e2fcee6894 t/helper/test-sha1: prepare for an unsafe mode
2: d343f5dc9e5 = 2: d8c1fc78b57 t/helper/test-tool: implement sha1-unsafe helper
base-commit: 8f8d6eee531b3fa1a8ef14f169b0cb5035f7a772
--
2.47.0.231.gd8c1fc78b57
next reply other threads:[~2024-11-05 19:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 19:05 Taylor Blau [this message]
2024-11-05 19:05 ` [PATCH v2 1/2] t/helper/test-sha1: prepare for an unsafe mode Taylor Blau
2024-11-06 1:38 ` Junio C Hamano
2024-11-07 0:48 ` brian m. carlson
2024-11-07 1:39 ` Jeff King
2024-11-07 1:49 ` brian m. carlson
2024-11-07 2:08 ` Jeff King
2024-11-07 3:08 ` Junio C Hamano
2024-11-07 21:30 ` Taylor Blau
2024-11-07 23:20 ` Taylor Blau
2024-11-08 17:26 ` Jeff King
2024-11-05 19:05 ` [PATCH v2 2/2] t/helper/test-tool: implement sha1-unsafe helper Taylor Blau
2024-11-07 1:47 ` [PATCH v2 0/2] t/helper/test-tool: implement 'sha1-unsafe' helper Jeff King
2024-11-07 2:05 ` brian m. carlson
2024-11-07 21:33 ` Taylor Blau
2024-11-08 17:23 ` Jeff King
2024-11-08 17:22 ` Jeff King
2024-11-07 21:36 ` Taylor Blau
2024-11-08 17:23 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1730833506.git.me@ttaylorr.com \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).