From: Taylor Blau <me@ttaylorr.com>
To: git@vger.kernel.org
Cc: Elijah Newren <newren@gmail.com>, Jeff King <peff@peff.net>,
Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 0/4] pack-bitmap: enable lookup tables by default, misc. cleanups
Date: Thu, 17 Apr 2025 17:12:10 -0400 [thread overview]
Message-ID: <cover.1744924321.git.me@ttaylorr.com> (raw)
This is a short series I extracted from a larger topic on reusing
"external"[^1] deltas during verbatim pack reuse.
As part of performance-testing that series, I realized that bitmap
lookup tables are not written by default. Since it has been a
significant period of time since their introduction, the first patch of
this series makes writing the lookup table extension the default
behavior. This is:
* pack-bitmap: write lookup table extension by default
The next three patches clean up some t/perf scripts that were redundant
now that lookup tables are the default behavior. Those are:
* p5312: removed duplicate performance test script
* t/perf: avoid testing bitmaps without lookup table
* t/perf/lib-bitmap.sh: avoid test_perf during setup
Thanks in advance for your review :-).
[^1]: The term I'm using to describe delta/base pairs which either (a)
are represented from different packs in a MIDX bitmap, or (b) the client
is known to already have the base.
Taylor Blau (4):
pack-bitmap: write lookup table extension by default
p5312: removed duplicate performance test script
t/perf: avoid testing bitmaps without lookup table
t/perf/lib-bitmap.sh: avoid test_perf during setup
Documentation/config/pack.adoc | 2 +-
builtin/multi-pack-index.c | 1 +
builtin/pack-objects.c | 2 +-
t/perf/lib-bitmap.sh | 2 +-
t/perf/p5310-pack-bitmaps.sh | 47 +++++-------
t/perf/p5311-pack-bitmaps-fetch.sh | 76 +++++++++----------
t/perf/p5312-pack-bitmaps-revs.sh | 34 ---------
t/perf/p5326-multi-pack-bitmaps.sh | 107 ++++++++++++---------------
t/perf/p5333-pseudo-merge-bitmaps.sh | 1 -
9 files changed, 106 insertions(+), 166 deletions(-)
delete mode 100755 t/perf/p5312-pack-bitmaps-revs.sh
base-commit: c152ae3ef50dc7bbbf5089571df5bba404a96e0d
--
2.49.0.226.g0e6cae136d
next reply other threads:[~2025-04-17 21:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 21:12 Taylor Blau [this message]
2025-04-17 21:12 ` [PATCH 1/4] pack-bitmap: write lookup table extension by default Taylor Blau
2025-04-17 22:04 ` Junio C Hamano
2025-04-18 9:33 ` Jeff King
2025-04-18 15:44 ` Junio C Hamano
2025-04-18 21:52 ` Taylor Blau
2025-04-17 21:12 ` [PATCH 2/4] p5312: removed duplicate performance test script Taylor Blau
2025-04-17 22:08 ` Junio C Hamano
2025-04-18 21:57 ` Taylor Blau
2025-04-17 21:12 ` [PATCH 3/4] t/perf: avoid testing bitmaps without lookup table Taylor Blau
2025-04-17 22:21 ` Junio C Hamano
2025-04-18 4:24 ` Junio C Hamano
2025-04-18 10:02 ` Jeff King
2025-04-17 21:12 ` [PATCH 4/4] t/perf/lib-bitmap.sh: avoid test_perf during setup Taylor Blau
2025-04-17 22:22 ` Junio C Hamano
2025-04-18 10:17 ` Jeff King
2025-05-02 21:21 ` [PATCH 0/4] pack-bitmap: enable lookup tables by default, misc. cleanups Junio C Hamano
2025-05-05 7:11 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1744924321.git.me@ttaylorr.com \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).