public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: git@vger.kernel.org
Cc: Patrick Steinhardt <ps@pks.im>, Jeff King <peff@peff.net>,
	Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 0/2] midx-write.c: do not optimize out writes with corrupt MIDXs
Date: Mon, 12 Jan 2026 18:44:53 -0500	[thread overview]
Message-ID: <cover.1768261435.git.me@ttaylorr.com> (raw)

These two patches came from my work on implementing incremental MIDX
layer compaction.

When rebasing on top of current 'master' (at the
time of writing, 8745eae506f (The 17th batch, 2026-01-11)), I noticed
an early 'test_done' in t5319 added by 6ce9d558ced (midx-write: skip
rewriting MIDX with `--stdin-packs` unless needed, 2025-12-10). The
series is structured as follows:

 - The first patch removes the extraneous 'test_done', which exposes a
   failing test which is marked as such.

 - The second patch explains and fixes the bug, un-marking the test
   as test_expect_failure.

I was originally planning on adding these onto my series under
tb/incremental-midx-part-3.2. But I opted to split these patches out
into their own topic to ensure they are picked up before v2.53.0 is
tagged, should the larger series not be ready by then.

Thanks in advance for your review!

Taylor Blau (2):
  t/t5319-multi-pack-index.sh: drop early 'test_done'
  midx-write.c: assume checksum-invalid MIDXs require an update

 midx-write.c                | 14 ++++++++++++++
 t/t5319-multi-pack-index.sh |  2 --
 2 files changed, 14 insertions(+), 2 deletions(-)


base-commit: 8745eae506f700657882b9e32b2aa00f234a6fb6
-- 
2.52.0.437.gcc6f76a88cd

             reply	other threads:[~2026-01-12 23:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-12 23:44 Taylor Blau [this message]
2026-01-12 23:45 ` [PATCH 1/2] t/t5319-multi-pack-index.sh: drop early 'test_done' Taylor Blau
2026-01-13  7:37   ` Patrick Steinhardt
2026-01-12 23:45 ` [PATCH 2/2] midx-write.c: assume checksum-invalid MIDXs require an update Taylor Blau
2026-01-13  7:38   ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1768261435.git.me@ttaylorr.com \
    --to=me@ttaylorr.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox