public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Phillip Wood <phillip.wood123@gmail.com>
To: git@vger.kernel.org
Cc: Ezekiel Newren <ezekielnewren@gmail.com>
Subject: [PATCH 0/2] xdiff: Remove unneeded members from xrecord_t and xdlclass_t
Date: Mon, 26 Jan 2026 10:48:50 +0000	[thread overview]
Message-ID: <cover.1769424529.git.phillip.wood@dunelm.org.uk> (raw)

From: Phillip Wood <phillip.wood@dunelm.org.uk>

This series has a couple of cleanups on top of 'en/xdiff-cleanup-2'
that reduce the sizes of the xrecord_t and xdlclass_t. Unfortunately
they conflict with 'en/xdiff-cleanup-3' in seen, in particular with
db8a50ca6b9 (xdiff: don't waste time guessing the number of lines,
2026-01-02). I'm not particularly convinced that moving the call to
xdl_classify_record() out of xdl_prepare_ctx() in that commit is
a good idea, but if we decide that we do want to stop classifying
lines in xdl_prepare_ctx() we can start passing the hashes out in a
separate array rather than wasting space in xrecord_t.

Base-Commit: 1faf5b085a171f9ba9a6d7a446e0de16acccb1dc
Published-As: https://github.com/phillipwood/git/releases/tag/pw%2Fxdiff-cleanup-xrecord_t-and-xdlclass_t%2Fv1
View-Changes-At: https://github.com/phillipwood/git/compare/1faf5b085...0d251dfba
Fetch-It-Via: git fetch https://github.com/phillipwood/git pw/xdiff-cleanup-xrecord_t-and-xdlclass_t/v1


Phillip Wood (2):
  xdiff: remove "line_hash" field from xrecord_t
  xdiff: remove unused data from xdlclass_t

 xdiff/xprepare.c | 20 ++++++++++++--------
 xdiff/xtypes.h   |  1 -
 2 files changed, 12 insertions(+), 9 deletions(-)

-- 
2.52.0.362.g884e03848a9


             reply	other threads:[~2026-01-26 10:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-26 10:48 Phillip Wood [this message]
2026-01-26 10:48 ` [PATCH 1/2] xdiff: remove "line_hash" field from xrecord_t Phillip Wood
2026-01-26 10:48 ` [PATCH 2/2] xdiff: remove unused data from xdlclass_t Phillip Wood
2026-01-26 17:35 ` [PATCH 0/2] xdiff: Remove unneeded members from xrecord_t and xdlclass_t Junio C Hamano
2026-02-10 20:39   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1769424529.git.phillip.wood@dunelm.org.uk \
    --to=phillip.wood123@gmail.com \
    --cc=ezekielnewren@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox