From: Mirko Faina <mroik@delayed.space>
To: git@vger.kernel.org
Cc: "Mirko Faina" <mroik@delayed.space>,
"Junio C Hamano" <gitster@pobox.com>, "Jeff King" <peff@peff.net>,
"Jean-Noël Avila" <jn.avila@free.fr>,
"Patrick Steinhardt" <ps@pks.im>, "Tian Yuchen" <cat@malon.dev>,
"Ben Knoble" <ben.knoble@gmail.com>
Subject: [PATCH v3 0/2] revision.c: implement --reverse=before for walks
Date: Fri, 24 Apr 2026 00:51:58 +0200 [thread overview]
Message-ID: <cover.1776984666.git.mroik@delayed.space> (raw)
In-Reply-To: <20260422002840.303477-4-mroik@delayed.space>
I've fixed the docs with the suggested changes by Jeff and applied some
styling fixes.
[1/2] revision.c: implement --reverse=before for walks (Mirko Faina)
[2/2] revision.c: reduce memory usage on reverse before (Mirko Faina)
Documentation/rev-list-options.adoc | 16 +++++--
revision.c | 73 +++++++++++++++++++++++++++--
revision.h | 8 +++-
t/t4202-log.sh | 66 ++++++++++++++++++++++++++
4 files changed, 153 insertions(+), 10 deletions(-)
Range-diff against v2:
1: 599a247d82 ! 1: 4864ac46dd revision.c: implement --reverse=before for walks
@@ Documentation/rev-list-options.adoc: With `--topo-order`, they would show 8 6 5
+ `--walk-reflogs`. If `after`, output the commits chosen to be
+ shown (see 'Commit Limiting' section above) in reverse order. If
+ `before`, reverse the commits before filtering with `Commit
-+ Limiting` options. This option can be used multiple times, last
-+ one is applied. When the argument for `--reverse` is omitted, if
-+ the current state is in no reverse, it defaults to `after`. If
-+ it is in any reversed state, it restores the original ordering
-+ by removing the reverse state.
++ Limiting` options. When multiple `--reverse=` options are given,
++ the final option overrides any previous options. The `--reverse`
++ option (with no specifier) behaves as `--reverse=after`, except
++ that, for historical reasons, it negates any previous reversed
++ state (so `--reverse --reverse` does nothing, nor does
++ `--reverse=before --reverse`. Note that `--reverse=before
++ --reverse --reverse` is the same as `--reverse=after`).
endif::git-shortlog[]
ifndef::git-shortlog[]
2: 480b322cf8 ! 2: 00489b0e52 revision.c: reduce memory usage on reverse before
@@ revision.c: static struct commit *get_revision_internal(struct rev_info *revs)
}
+static void retrieve_with_window(struct rev_info *revs, int max_count,
-+ struct commit_list **reversed)
++ struct commit_list **reversed)
+{
+ struct commit *c;
+ struct commit_list *into_queue = NULL;
@@ revision.c: static struct commit *get_revision_internal(struct rev_info *revs)
+ }
+ }
+
-+ while (outo_count) {
-+ c = pop_commit(&outo_queue);
-+ outo_count--;
++ while ((c = pop_commit(&outo_queue)))
+ commit_list_insert(c, reversed);
-+ }
-+
-+ while (into_count) {
-+ c = pop_commit(&into_queue);
-+ into_count--;
++ while ((c = pop_commit(&into_queue)))
+ commit_list_insert(c, &outo_queue);
-+ outo_count++;
-+ }
-+
-+ while (outo_count) {
-+ c = pop_commit(&outo_queue);
-+ outo_count--;
++ while ((c = pop_commit(&outo_queue)))
+ commit_list_insert(c, reversed);
-+ }
+}
+
struct commit *get_revision(struct rev_info *revs)
--
2.54.0
next prev parent reply other threads:[~2026-04-23 22:52 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-18 16:47 [PATCH] revision.c: implement --reverse=before for walks Mirko Faina
2026-04-18 18:20 ` Tian Yuchen
2026-04-18 18:42 ` Mirko Faina
2026-04-18 18:51 ` Mirko Faina
2026-04-20 16:06 ` Junio C Hamano
2026-04-20 17:08 ` Tian Yuchen
2026-04-20 23:50 ` Mirko Faina
2026-04-19 12:06 ` Ben Knoble
2026-04-19 18:11 ` Mirko Faina
2026-04-19 19:12 ` D. Ben Knoble
2026-04-19 20:31 ` Mirko Faina
2026-04-20 0:21 ` Jeff King
2026-04-20 9:33 ` Mirko Faina
2026-04-20 10:30 ` Mirko Faina
2026-04-21 3:48 ` Jeff King
2026-04-22 18:24 ` D. Ben Knoble
2026-04-22 19:42 ` Mirko Faina
2026-04-20 0:04 ` Jeff King
2026-04-20 9:22 ` Mirko Faina
2026-04-22 0:28 ` [PATCH v2 0/2] " Mirko Faina
2026-04-22 0:30 ` Mirko Faina
2026-04-23 22:51 ` Mirko Faina [this message]
2026-04-23 22:51 ` [PATCH v3 1/2] " Mirko Faina
2026-04-28 1:45 ` Junio C Hamano
2026-04-23 22:52 ` [PATCH v3 2/2] revision.c: reduce memory usage on reverse before Mirko Faina
2026-04-27 0:24 ` [PATCH v4 0/2] revision.c: implement --reverse=before for walks Mirko Faina
2026-04-27 0:24 ` [PATCH v4 1/2] " Mirko Faina
2026-04-27 6:45 ` Junio C Hamano
2026-04-27 7:33 ` Johannes Sixt
2026-04-27 12:30 ` Junio C Hamano
2026-04-27 13:58 ` Chris Torek
2026-04-27 16:48 ` [PATCH v4 1/2] revision.c: implement -b-reverse=before " Mirko Faina
2026-04-28 1:46 ` Junio C Hamano
2026-04-28 1:45 ` [PATCH v4 1/2] revision.c: implement --reverse=before " Junio C Hamano
2026-04-27 0:24 ` [PATCH v4 2/2] revision.c: reduce memory usage on reverse before Mirko Faina
2026-04-28 1:46 ` Junio C Hamano
2026-04-30 19:52 ` [PATCH v5] revision.c: implement --max-count-oldest Mirko Faina
2026-05-04 5:19 ` Junio C Hamano
2026-05-04 13:08 ` Mirko Faina
2026-05-05 21:54 ` [PATCH v6] " Mirko Faina
2026-05-06 6:45 ` Johannes Sixt
2026-05-06 12:54 ` Mirko Faina
2026-05-07 9:20 ` Junio C Hamano
2026-05-08 0:09 ` Mirko Faina
2026-05-09 12:46 ` Jean-Noël AVILA
2026-05-10 0:41 ` Mirko Faina
2026-05-09 21:01 ` Junio C Hamano
2026-05-10 0:48 ` Mirko Faina
2026-05-09 11:01 ` [PATCH v5] " Junio C Hamano
2026-05-10 0:36 ` Mirko Faina
2026-04-22 0:28 ` [PATCH v2 1/2] revision.c: implement --reverse=before for walks Mirko Faina
2026-04-22 22:44 ` Jeff King
2026-04-22 22:53 ` Mirko Faina
2026-04-22 0:28 ` [PATCH v2 2/2] revision.c: reduce memory usage on reverse before Mirko Faina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1776984666.git.mroik@delayed.space \
--to=mroik@delayed.space \
--cc=ben.knoble@gmail.com \
--cc=cat@malon.dev \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jn.avila@free.fr \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox