Git development
 help / color / mirror / Atom feed
From: Laveesh Bansal <laveeshb@laveeshbansal.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"Patrick Steinhardt" <ps@pks.im>,
	"Karthik Nayak" <karthik.188@gmail.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: [PATCH v2 0/2] builtin/reflog: expire each reflog only once
Date: Tue, 10 Nov 2026 07:26:39 -0800	[thread overview]
Message-ID: <cover.1794324064.git.laveeshb@laveeshbansal.com> (raw)
In-Reply-To: <20261108012213.89468-1-laveeshb@laveeshbansal.com>

This series makes "git reflog expire" expire each reflog only once.  1/2
puts the --all and the named-ref paths in one loop without changing
behavior.  2/2 skips a reflog that was already expired in this run, so
a name given twice, or one that --all also covers, is no longer expired
and reported twice.

v1 was the refactor alone.  I had kept it free of behavior changes and
planned to handle repeated reflogs in a later patch.  After the
discussion on v1 [1][2], I am bringing that change into v2 as a second
patch, which keeps the refactor separate.

Changes since v1: 1/2 only has a new commit message, and 2/2 is new.

I ran the full test suite, and the reflog tests with reftable, sha256
and SANITIZE=leak.  Against the base, the output differs only where a
reflog is reached twice.

Assisted-by: Claude Sonnet 5.5

[1] https://lore.kernel.org/git/avLDE1gGsjjy2ryd@pks.im/
[2] https://lore.kernel.org/git/xmqqwlqlydo2.fsf@gitster.g/


Laveesh Bansal (2):
  builtin/reflog: expire --all and named refs in one loop
  builtin/reflog: expire each reflog only once

 builtin/reflog.c  | 56 ++++++++++++++++++++++++++---------------------
 t/t1410-reflog.sh | 14 ++++++++++++
 2 files changed, 45 insertions(+), 25 deletions(-)

-- 
2.54.0


  parent reply	other threads:[~2026-11-10 15:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-08  1:22 [PATCH] builtin/reflog: expire --all and named refs in one loop Laveesh Bansal
2026-11-09  9:40 ` Patrick Steinhardt
2026-11-09 16:13   ` Laveesh Bansal
2026-11-10  7:09     ` Patrick Steinhardt
2026-11-09 20:04   ` Junio C Hamano
2026-11-10 15:26 ` Laveesh Bansal [this message]
2026-11-10 15:26   ` [PATCH v2 1/2] " Laveesh Bansal
2026-11-10 15:26   ` [PATCH v2 2/2] builtin/reflog: expire each reflog only once Laveesh Bansal
2026-11-11 12:42     ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1794324064.git.laveeshb@laveeshbansal.com \
    --to=laveeshb@laveeshbansal.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=karthik.188@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox