git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Benjamin Kudria" <ben@kudria.net>
To: git@vger.kernel.org
Subject: Git's config core.pager doesn't respect color.pager
Date: Tue, 22 Jul 2008 22:10:17 -0400	[thread overview]
Message-ID: <d129c0140807221910j37f40e72se9f411d6424077de@mail.gmail.com> (raw)

I'm seeing a problem with git.  It's easier to demonstrate than
explain.  The relevant parts of my .gitconfig:

[core]
	pager = tig

[color]
	diff = auto
	pager = false

tig is a console-based git client that can also act as a pager,
colorizing git output.

So, with the above config, when I do:

git diff | tig

Everything works correctly - git sends no color codes, because of
color.pager = false.

However, if I do just:

git diff

git uses core.pager to display the output, but still sends color
codes, which is OK for, say, less, bit not so good for tig, which does
it's own colorizing, and displays the color codes git sends as-is.

Shouldn't core.pager respect color.pager, and not send the color codes?

Benjamin Kudria

-- 
http://ben.kudria.net | Jabber: ben@kudria.net

             reply	other threads:[~2008-07-23  2:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-23  2:10 Benjamin Kudria [this message]
2008-07-28  7:25 ` Git's config core.pager doesn't respect color.pager Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d129c0140807221910j37f40e72se9f411d6424077de@mail.gmail.com \
    --to=ben@kudria.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).