From: Brian Collins <bricollins@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Nanako Shiraishi <nanako3@lavabit.com>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH] RFC Allow case insensitive search flag with git-grep for fixed-strings
Date: Mon, 16 Nov 2009 08:58:26 -0800 [thread overview]
Message-ID: <d1c0fbfa0911160858k2cdd35bfvf27df2a5c97348ad@mail.gmail.com> (raw)
In-Reply-To: <20091116162533.GA30737@coredump.intra.peff.net>
> 1. The patch was line-wrapped; I had to de-munge it manually to apply.
Ugh, does gmail do this? Sorry
> 3. No signed-off-by. Brian, can you please acknowledge the DCO with a
> signoff?
Signed-off-by: Brian Collins <bricollins@gmail.com>
> 4. The patch introduced some stray trailing whitespace.
>
> 5. There were a few style fixups, like omitting braces for a
> single-line conditional.
Again sorry, thought the opposite was in the style guide.
--
Brian Collins
next prev parent reply other threads:[~2009-11-16 16:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-30 1:21 [PATCH] RFC Allow case insensitive search flag with git-grep for fixed-strings Brian Collins
2009-11-06 8:48 ` Jeff King
2009-11-06 9:22 ` Brian Collins
2009-11-06 10:00 ` Junio C Hamano
2009-11-06 10:13 ` Jeff King
2009-11-07 0:00 ` Junio C Hamano
2009-11-16 10:50 ` Nanako Shiraishi
2009-11-16 16:25 ` Jeff King
2009-11-16 16:58 ` Brian Collins [this message]
2009-11-16 18:00 ` Brandon Casey
2009-11-16 23:36 ` Junio C Hamano
2009-11-17 0:06 ` Junio C Hamano
2009-11-17 7:38 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1c0fbfa0911160858k2cdd35bfvf27df2a5c97348ad@mail.gmail.com \
--to=bricollins@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nanako3@lavabit.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).