From: "Torsten Bögershausen" <tboegi@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Sven Strickroth <sven@cs-ware.de>,
git@vger.kernel.org, peff@peff.net, johannes.schindelin@gmx.de
Subject: Re: [PATCH] Unbreak real_path on Windows for already absolute paths (with Visual Studio)
Date: Wed, 10 Apr 2019 07:32:35 +0200 [thread overview]
Message-ID: <d1cf10ec-ca57-09e3-cf00-3be87dec06ee@web.de> (raw)
In-Reply-To: <xmqqv9zn2kjs.fsf@gitster-ct.c.googlers.com>
On 2019-04-09 18:46, Junio C Hamano wrote:
> Torsten Bögershausen <tboegi@web.de> writes:
>
>>> 1cadad6f6 removes mingw_offset_1st_component from mingw.c which is
>>> included by msvc.c. Then the in git-compat.h the new file
>>> "compat/win32/path-utils.h" is only included for __CYGWIN__ and
>>> __MINGW32__, here _MSC_VER is missing -> that's the regression.
>>>
>>
>> OK, good.
>> If possible, I would like to see this kind of information
>> in the commit message.
>> Thanks for cleaning up my mess.
>
> Thanks, both. Should I wait for an update that fixes the proposed
> log message?
>
It seems that I haven't read all messages in my mailbox (or messages crossed).
The V2 patch describes the problem well and looks OK for me.
next prev parent reply other threads:[~2019-04-10 5:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 11:16 [PATCH] Unbreak real_path on Windows for already absolute paths (with Visual Studio) Sven Strickroth
2019-04-09 2:36 ` Taylor Blau
2019-04-09 5:53 ` Torsten Bögershausen
2019-04-09 7:34 ` Sven Strickroth
2019-04-08 11:26 ` [PATCH v2] MSVC: Unbreak real_path for Windows paths Sven Strickroth
2019-04-09 11:45 ` Junio C Hamano
2019-04-09 16:19 ` [PATCH] Unbreak real_path on Windows for already absolute paths (with Visual Studio) Torsten Bögershausen
2019-04-09 16:46 ` Junio C Hamano
2019-04-10 5:32 ` Torsten Bögershausen [this message]
2019-04-12 1:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1cf10ec-ca57-09e3-cf00-3be87dec06ee@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=peff@peff.net \
--cc=sven@cs-ware.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).