From: "Caio Marcelo" <cmarcelo@gmail.com>
To: "Robin Rosenberg" <robin.rosenberg.lists@dewire.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: Binary files in format-patch
Date: Thu, 8 May 2008 17:21:53 -0300 [thread overview]
Message-ID: <d280d7f10805081321q7a09b61ke06a1c945650d880@mail.gmail.com> (raw)
In-Reply-To: <200805061119.14792.robin.rosenberg.lists@dewire.com>
> > Wouldn't be nice to allow this code path to happen via some
> > --omit-binary / --no-binary option to be checked in cmd_format_patch?
> > (I could provide a patch for this, if you think it's a good idea).
>
> Sounds reasonable. I'd say --no-binary is the right one here.
Commited a patch couple a days ago. Could anyone take a look? I've
tried to reduce the changes to a minimum.
Cheers,
Caio Marcelo
next prev parent reply other threads:[~2008-05-08 20:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 22:55 Binary files in format-patch Caio Marcelo
2008-05-05 23:01 ` Shawn O. Pearce
2008-05-05 23:10 ` Caio Marcelo
2008-05-06 9:19 ` Robin Rosenberg
2008-05-08 20:21 ` Caio Marcelo [this message]
2008-05-08 20:25 ` Caio Marcelo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d280d7f10805081321q7a09b61ke06a1c945650d880@mail.gmail.com \
--to=cmarcelo@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=robin.rosenberg.lists@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).