From: Beat Bolli <dev+git@drbeat.li>
To: Junio C Hamano <gitster@pobox.com>, Beat Bolli <bb@drbeat.li>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH 3/3] color: add support for 12-bit RGB colors
Date: Mon, 29 Apr 2024 19:42:09 +0200 [thread overview]
Message-ID: <d2d5bbfc-d2bb-4112-a12d-f19950125cb5@drbeat.li> (raw)
In-Reply-To: <xmqqo79sulqh.fsf@gitster.g>
On 29.04.2024 19:23, Junio C Hamano wrote:
> "Beat Bolli" <bb@drbeat.li> writes:
>
>> diff --git a/color.h b/color.h
>> index bb28343be210..7ed259a35bb4 100644
>> --- a/color.h
>> +++ b/color.h
>> @@ -112,7 +112,8 @@ int want_color_fd(int fd, int var);
>> * Translate a Git color from 'value' into a string that the terminal can
>> * interpret and store it into 'dst'. The Git color values are of the form
>> * "foreground [background] [attr]" where fore- and background can be a color
>> - * name ("red"), a RGB code (#0xFF0000) or a 256-color-mode from the terminal.
>> + * name ("red"), a RGB code (#FF0000 or #F00) or a 256-color-mode from the
>> + * terminal.
>> */
>
> Good. Hopefully we do not have such extra 0x in our end-user facing
> documentation?
No, this was the only '#0x' I found. config.txt is fine as per the first
hunk.
next prev parent reply other threads:[~2024-04-29 17:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 16:48 [PATCH 0/3] color: add support for 12-bit RGB colors Beat Bolli
2024-04-29 16:48 ` [PATCH 1/3] t/t4026-color: remove an extra double quote character Beat Bolli
2024-04-30 10:59 ` Jeff King
2024-04-29 16:48 ` [PATCH 2/3] t/t4026-color: add test coverage for invalid RGB colors Beat Bolli
2024-04-29 16:48 ` [PATCH 3/3] color: add support for 12-bit " Beat Bolli
2024-04-29 17:23 ` Junio C Hamano
2024-04-29 17:42 ` Beat Bolli [this message]
2024-04-30 10:57 ` Jeff King
2024-04-30 17:31 ` Junio C Hamano
2024-04-30 18:41 ` Junio C Hamano
2024-04-30 19:01 ` Junio C Hamano
2024-05-03 17:47 ` Jeff King
2024-04-29 21:37 ` [PATCH 0/3] " Taylor Blau
2024-05-02 11:03 ` [PATCH v2 " Beat Bolli
2024-05-02 11:03 ` [PATCH v2 1/3] t/t4026-color: remove an extra double quote character Beat Bolli
2024-05-02 11:03 ` [PATCH v2 2/3] t/t4026-color: add test coverage for invalid RGB colors Beat Bolli
2024-05-02 11:03 ` [PATCH v2 3/3] color: add support for 12-bit " Beat Bolli
2024-05-02 16:29 ` [PATCH v2 0/3] " Junio C Hamano
2024-05-03 17:48 ` Jeff King
2024-05-03 19:31 ` Beat Bolli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2d5bbfc-d2bb-4112-a12d-f19950125cb5@drbeat.li \
--to=dev+git@drbeat.li \
--cc=bb@drbeat.li \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).